database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-28007 Deprecate Spider plugin variables regarding statistics persistence

Browse Source 
Deprecate the following variables:

* spider_store_last_crd
* spider_store_last_sts
* spider_load_crd_at_startup
* spider_load_sts_at_startup
This commit is contained in:
Nayuta Yanagisawa
2022-04-05 16:55:42 +09:00
parent 3be8f66185
commit 7310e93ef6
3 changed files with 42 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
storage/spider/mysql-test/spider/r/variable_deprecation.result
View File

@@ -81,6 +81,31 @@ Warning 1287 '@@spider_xa_register_mode' is deprecated and will be removed in a
SHOW VARIABLES LIKE "spider_xa_register_mode"; SHOW VARIABLES LIKE "spider_xa_register_mode";
Variable_name Value Variable_name Value
spider_xa_register_mode 0 spider_xa_register_mode 0
# MDEV-28007 Deprecate Spider plugin variables regarding statistics persistence
SET GLOBAL spider_store_last_sts = 0;
Warnings:
Warning 1287 '@@spider_store_last_sts' is deprecated and will be removed in a future release
SHOW VARIABLES LIKE "spider_store_last_sts";
Variable_name Value
spider_store_last_sts 0
SET GLOBAL spider_store_last_crd = 0;
Warnings:
Warning 1287 '@@spider_store_last_crd' is deprecated and will be removed in a future release
SHOW VARIABLES LIKE "spider_store_last_crd";
Variable_name Value
spider_store_last_crd 0
SET GLOBAL spider_load_sts_at_startup = 0;
Warnings:
Warning 1287 '@@spider_load_sts_at_startup' is deprecated and will be removed in a future release
SHOW VARIABLES LIKE "spider_load_sts_at_startup";
Variable_name Value
spider_load_sts_at_startup 0
SET GLOBAL spider_load_crd_at_startup = 0;
Warnings:
Warning 1287 '@@spider_load_crd_at_startup' is deprecated and will be removed in a future release
SHOW VARIABLES LIKE "spider_load_crd_at_startup";
Variable_name Value
spider_load_crd_at_startup 0
DROP DATABASE auto_test_local; DROP DATABASE auto_test_local;
for master_1 for master_1
for child2 for child2

13
storage/spider/mysql-test/spider/t/variable_deprecation.test
View File

@@ -50,6 +50,19 @@ DROP TABLE tbl_b;
SET spider_xa_register_mode = 0; SET spider_xa_register_mode = 0;
SHOW VARIABLES LIKE "spider_xa_register_mode"; SHOW VARIABLES LIKE "spider_xa_register_mode";
--echo # MDEV-28007 Deprecate Spider plugin variables regarding statistics persistence
SET GLOBAL spider_store_last_sts = 0;
SHOW VARIABLES LIKE "spider_store_last_sts";
SET GLOBAL spider_store_last_crd = 0;
SHOW VARIABLES LIKE "spider_store_last_crd";
SET GLOBAL spider_load_sts_at_startup = 0;
SHOW VARIABLES LIKE "spider_load_sts_at_startup";
SET GLOBAL spider_load_crd_at_startup = 0;
SHOW VARIABLES LIKE "spider_load_crd_at_startup";
DROP DATABASE auto_test_local; DROP DATABASE auto_test_local;
--disable_query_log --disable_query_log

8
storage/spider/spd_param.cc
View File

@@ -3222,7 +3222,7 @@ static int spider_store_last_sts;
static MYSQL_SYSVAR_INT( static MYSQL_SYSVAR_INT(
store_last_sts, store_last_sts,
spider_store_last_sts, spider_store_last_sts,
PLUGIN_VAR_RQCMDARG, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_DEPRECATED,
"Store last sts result into system table", "Store last sts result into system table",
NULL, NULL,
spider_use_table_value_deprecated, spider_use_table_value_deprecated,
@@ -3249,7 +3249,7 @@ static int spider_store_last_crd;
static MYSQL_SYSVAR_INT( static MYSQL_SYSVAR_INT(
store_last_crd, store_last_crd,
spider_store_last_crd, spider_store_last_crd,
PLUGIN_VAR_RQCMDARG, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_DEPRECATED,
"Store last crd result into system table", "Store last crd result into system table",
NULL, NULL,
spider_use_table_value_deprecated, spider_use_table_value_deprecated,
@@ -3276,7 +3276,7 @@ static int spider_load_sts_at_startup;
static MYSQL_SYSVAR_INT( static MYSQL_SYSVAR_INT(
load_sts_at_startup, load_sts_at_startup,
spider_load_sts_at_startup, spider_load_sts_at_startup,
PLUGIN_VAR_RQCMDARG, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_DEPRECATED,
"Load sts from system table at startup", "Load sts from system table at startup",
NULL, NULL,
spider_use_table_value_deprecated, spider_use_table_value_deprecated,
@@ -3303,7 +3303,7 @@ static int spider_load_crd_at_startup;
static MYSQL_SYSVAR_INT( static MYSQL_SYSVAR_INT(
load_crd_at_startup, load_crd_at_startup,
spider_load_crd_at_startup, spider_load_crd_at_startup,
PLUGIN_VAR_RQCMDARG, PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_DEPRECATED,
"Load crd from system table at startup", "Load crd from system table at startup",
NULL, NULL,
spider_use_table_value_deprecated, spider_use_table_value_deprecated,