database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

1. don't crash on failing to load a plugin with newer MYSQL_PLUGIN_INTERFACE_VERSION

Browse Source 
2. don't copy st_mysql_plugin structure unnecessary (sizeof hasn't changed)
This commit is contained in:
Sergei Golubchik
2010-03-12 20:05:21 +01:00
parent edfd875fc1
commit 71b3e46b01
2 changed files with 32 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sql/sql_plugin.cc
View File

@ -333,7 +333,7 @@ static inline void free_plugin_mem(struct st_plugin_dl *p)
dlclose(p->handle); dlclose(p->handle);
#endif #endif
my_free(p->dl.str, MYF(MY_ALLOW_ZERO_PTR)); my_free(p->dl.str, MYF(MY_ALLOW_ZERO_PTR));
if (p->version != MYSQL_PLUGIN_INTERFACE_VERSION) if (p->allocated)
my_free((uchar*)p->plugins, MYF(MY_ALLOW_ZERO_PTR)); my_free((uchar*)p->plugins, MYF(MY_ALLOW_ZERO_PTR));
} }
@ -454,13 +454,15 @@ static st_plugin_dl *plugin_dl_add(const LEX_STRING *dl, int report)
#endif #endif
} }
if (sizeof_st_plugin != sizeof(st_mysql_plugin))
{
for (i= 0; for (i= 0;
((struct st_mysql_plugin *)(ptr+i*sizeof_st_plugin))->info; ((struct st_mysql_plugin *)(ptr+i*sizeof_st_plugin))->info;
i++) i++)
/* no op */; /* no op */;
cur= (struct st_mysql_plugin*) cur= (struct st_mysql_plugin*)
my_malloc(i*sizeof(struct st_mysql_plugin), MYF(MY_ZEROFILL|MY_WME)); my_malloc((i+1)*sizeof(struct st_mysql_plugin), MYF(MY_ZEROFILL|MY_WME));
if (!cur) if (!cur)
{ {
free_plugin_mem(&plugin_dl); free_plugin_mem(&plugin_dl);
@ -481,6 +483,8 @@ static st_plugin_dl *plugin_dl_add(const LEX_STRING *dl, int report)
memcpy(cur+i, old, min(sizeof(cur[i]), sizeof_st_plugin)); memcpy(cur+i, old, min(sizeof(cur[i]), sizeof_st_plugin));
sym= cur; sym= cur;
plugin_dl.allocated= true;
}
} }
plugin_dl.plugins= (struct st_mysql_plugin *)sym; plugin_dl.plugins= (struct st_mysql_plugin *)sym;

1
sql/sql_plugin.h
View File

@ -64,6 +64,7 @@ struct st_plugin_dl
void *handle; void *handle;
struct st_mysql_plugin *plugins; struct st_mysql_plugin *plugins;
int version; int version;
bool allocated;
uint ref_count; /* number of plugins loaded from the library */ uint ref_count; /* number of plugins loaded from the library */
}; };