database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Bug#15920 (Temporary tables are not logged in binlog):

Browse Source 
Fixing faulty tests preventing some CREATE TEMPORARY TABLE statements
  from being binlogged under statement-based replication.
This commit is contained in:
mats@mysql.com
2005-12-22 11:09:50 +01:00
parent 4eee14fb70
commit 6dd5e5619e
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/t/disabled.def
View File

@ -22,6 +22,6 @@ group_min_max : Bug #15448
innodb_concurrent : Results are not deterministic, Elliot will fix (BUG#3300) innodb_concurrent : Results are not deterministic, Elliot will fix (BUG#3300)
subselect : Bug#15706 subselect : Bug#15706
type_time : Bug#15805 type_time : Bug#15805
rpl000002 : Bug#15920 Temporary tables are not binlogged in SBR #rpl000002 : Bug#15920 Temporary tables are not binlogged in SBR
ps_7ndb : Bug#15923 Core dump in RBR mode when executing test suite ps_7ndb : Bug#15923 Core dump in RBR mode when executing test suite
sp_trans : Bug#15924 Code dump in RBR mode when executing test suite sp_trans : Bug#15924 Code dump in RBR mode when executing test suite

8
sql/sql_table.cc
View File

@ -1915,10 +1915,12 @@ bool mysql_create_table(THD *thd,const char *db, const char *table_name,
- It is an internal temporary table, - It is an internal temporary table,
- Row-based logging is used and it we are creating a temporary table, or - Row-based logging is used and it we are creating a temporary table, or
- The binary log is not open. - The binary log is not open.
Otherwise, the statement shall be binlogged.
*/ */
if (!internal_tmp_table && if (!internal_tmp_table &&
!(binlog_row_based && (!binlog_row_based ||
(create_info->options & HA_LEX_CREATE_TMP_TABLE))) (binlog_row_based &&
!(create_info->options & HA_LEX_CREATE_TMP_TABLE))))
write_bin_log(thd, TRUE, thd->query, thd->query_length); write_bin_log(thd, TRUE, thd->query, thd->query_length);
error= FALSE; error= FALSE;
unlock_and_end: unlock_and_end:
@ -3112,7 +3114,7 @@ bool mysql_create_like_table(THD* thd, TABLE_LIST* table,
Case 3 and 4 does nothing under RBR Case 3 and 4 does nothing under RBR
*/ */
} }
else if (!(create_info->options & HA_LEX_CREATE_TMP_TABLE)) else
write_bin_log(thd, TRUE, thd->query, thd->query_length); write_bin_log(thd, TRUE, thd->query, thd->query_length);
res= FALSE; res= FALSE;