database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

MDEV-30925 Assertion failed in translog_write_record in ONLINE ALTER + Aria

Browse Source 
This is the corner case of ONLINE ALTER vs ha_maria vs App-time Periods.

When a Delete_rows_event (or update) is executed, a lookup handler may be
created, normally to serve long unique index needs, by a call of
handler::prepare_for_insert. This function also creates a lookup handler
if an application-time period exists in a table.

A difference with a usual call of prepare_for_insert is that transactions
are disabled for this table during ALTER TABLE. See
mysql_trans_prepare_alter_copy_data call in copy_data_between_tables.

Then, ha_maria calls _ma_tmp_disable_logging_for_table during
ha_maria::external_lock. It never happened so before, that two handlers
would be created for write to a single ha_maria table under transactions
disabled.

Hence, the fix handles this scenario.
It could be done otherwise, by not creating this lookup handler (since it's
not used anyway during ONLINE ALTER), but architecturally, two handlers
should be supported.

Avoiding the creation of lookup handler could be done here additionally,
but with a cost of slowing down other more generic cases, with an
additional check of online alter table active.
This commit is contained in:
Nikita Malyavin
2023-03-26 00:26:05 +03:00
committed by Sergei Golubchik
parent 6f78efc01c
commit 6b35d6a909
3 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mysql-test/main/alter_table_online_debug.result
View File

@ -1176,5 +1176,19 @@ drop table t1;
drop procedure p;
set debug_sync=reset;
#
# MDEV-30902 Server crash in LEX::first_lists_tables_same
#
create table t (id int, s date, e date, period for p(s,e),
unique(id, p without overlaps)) engine=aria;
insert into t values (1,'1971-01-01','1971-01-02');
set debug_sync= 'alter_table_online_before_lock signal lock wait_for goon';
alter table t force;
connection con1;
set debug_sync= 'now wait_for lock';
delete from t;
set debug_sync= 'now signal goon';
connection default;
drop table t;
#
# End of 11.2 tests
#