From 69f3bb67f572d0b55f5bf49cb90aedb62412568c Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 26 Oct 2006 18:34:24 +0200 Subject: [PATCH] Bug #14262 SP: DROP PROCEDURE|VIEW (maybe more) write to binlog too late (race cond) - Rmove duplicate code to log a "DROP VIEW..", must be a merge miss sql/sql_view.cc: The query should only be logged to binlog once and that is if the drop didn't produce any errors Removing the duplicate as that must have been a merge error --- sql/sql_view.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sql/sql_view.cc b/sql/sql_view.cc index e3951e78df8..19072bc0fc5 100644 --- a/sql/sql_view.cc +++ b/sql/sql_view.cc @@ -1418,13 +1418,6 @@ bool mysql_drop_view(THD *thd, TABLE_LIST *views, enum_drop_mode drop_mode) sp_cache_invalidate(); } - if (mysql_bin_log.is_open()) - { - thd->clear_error(); - thd->binlog_query(THD::MYSQL_QUERY_TYPE, - thd->query, thd->query_length, FALSE, FALSE); - } - if (error) { VOID(pthread_mutex_unlock(&LOCK_open));