database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Use generic Histogram_base class for Histogram_builders

Browse Source 
This fixes the wrong calculation for avg_frequency in json histograms
by replacing the specific histogram objects with the generic Histogram_base class.

It also restores get/set size functions as they were useful in calculating fields
for binary histogram.

Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
This commit is contained in:
Michael Okoko
2021-08-11 06:58:18 +01:00
committed by Sergei Petrunia
parent 21e0f5487f
commit 69f24c238e
3 changed files with 32 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
sql/sql_statistics.h
View File

@ -179,7 +179,11 @@ public:
return 1.0;
};
virtual ~Histogram_base(){}
// Legacy: return the size of the histogram on disk.
// This will be stored in mysql.column_stats.hist_size column.
// Newer, JSON-based histograms may return 0.
virtual uint get_size()=0;
virtual ~Histogram_base()= default;
};
class Histogram_binary : public Histogram_base
@ -283,7 +287,9 @@ public:
void set_values (uchar *vals) override { values= (uchar *) vals; }
void set_size (ulonglong sz) override { size= (uint8) sz; }
bool is_available() override { return get_width() > 0 && get_values(); }
uint get_size() override {return (uint)size;}
bool is_available() override { return get_size() > 0 && get_values(); }
/*
This function checks that histograms should be usable only when
@ -385,6 +391,10 @@ public:
void set_size (ulonglong sz) override {size = (uint8) sz; }
uint get_size() override {
return size;
}
void init_for_collection(MEM_ROOT *mem_root, Histogram_type htype_arg, ulonglong size) override;
bool is_available() override {return get_width() > 0 /*&& get_values()*/; }
@ -395,9 +405,9 @@ public:
is_available();
}
void set_values (uchar *vals) override { values= vals; }
void set_values (uchar *vals) override { values= (uchar *) vals; }
uchar *get_values() override { return values; }
uchar *get_values() override { return (uchar *) values; }
double range_selectivity(double min_pos, double max_pos) override {return 0.1;}