mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
Merge 11.0 into 11.1
This commit is contained in:
@@ -324,8 +324,6 @@ static void update_tmptable_sum_func(Item_sum **func,TABLE *tmp_table);
|
||||
static void copy_sum_funcs(Item_sum **func_ptr, Item_sum **end);
|
||||
static bool add_ref_to_table_cond(THD *thd, JOIN_TAB *join_tab);
|
||||
static bool setup_sum_funcs(THD *thd, Item_sum **func_ptr);
|
||||
static bool prepare_sum_aggregators(THD *thd, Item_sum **func_ptr,
|
||||
bool need_distinct);
|
||||
static bool init_sum_functions(Item_sum **func, Item_sum **end);
|
||||
static bool update_sum_func(Item_sum **func);
|
||||
static void select_describe(JOIN *join, bool need_tmp_table,bool need_order,
|
||||
@@ -2410,6 +2408,10 @@ JOIN::optimize_inner()
|
||||
select_lex->attach_to_conds,
|
||||
&cond_value);
|
||||
sel->attach_to_conds.empty();
|
||||
Json_writer_object wrapper(thd);
|
||||
Json_writer_object pushd(thd, "condition_pushdown_from_having");
|
||||
pushd.add("conds", conds);
|
||||
pushd.add("having", having);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -4297,7 +4299,7 @@ JOIN::create_postjoin_aggr_table(JOIN_TAB *tab, List<Item> *table_fields,
|
||||
if (make_sum_func_list(all_fields, fields_list, true))
|
||||
goto err;
|
||||
if (prepare_sum_aggregators(thd, sum_funcs,
|
||||
!(tables_list &&
|
||||
!(tables_list &&
|
||||
join_tab->is_using_agg_loose_index_scan())))
|
||||
goto err;
|
||||
if (setup_sum_funcs(thd, sum_funcs))
|
||||
@@ -14929,7 +14931,8 @@ end_sj_materialize(JOIN *join, JOIN_TAB *join_tab, bool end_of_records)
|
||||
if (item->is_null())
|
||||
DBUG_RETURN(NESTED_LOOP_OK);
|
||||
}
|
||||
fill_record(thd, table, table->field, sjm->sjm_table_cols, TRUE, FALSE);
|
||||
fill_record(thd, table, table->field, sjm->sjm_table_cols, true, false,
|
||||
true);
|
||||
if (unlikely(thd->is_error()))
|
||||
DBUG_RETURN(NESTED_LOOP_ERROR); /* purecov: inspected */
|
||||
if (unlikely((error= table->file->ha_write_tmp_row(table->record[0]))))
|
||||
@@ -18418,6 +18421,7 @@ Item *eliminate_item_equal(THD *thd, COND *cond, COND_EQUAL *upper_levels,
|
||||
|
||||
if (!eq_item || eq_item->set_cmp_func(thd))
|
||||
return 0;
|
||||
eq_item->eval_not_null_tables(0);
|
||||
eq_item->quick_fix_field();
|
||||
}
|
||||
current_sjm= field_sjm;
|
||||
@@ -18475,6 +18479,7 @@ Item *eliminate_item_equal(THD *thd, COND *cond, COND_EQUAL *upper_levels,
|
||||
{
|
||||
res->quick_fix_field();
|
||||
res->update_used_tables();
|
||||
res->eval_not_null_tables(0);
|
||||
}
|
||||
|
||||
return res;
|
||||
@@ -20144,6 +20149,12 @@ Item_cond::remove_eq_conds(THD *thd, Item::cond_result *cond_value,
|
||||
bool and_level= functype() == Item_func::COND_AND_FUNC;
|
||||
List<Item> *cond_arg_list= argument_list();
|
||||
|
||||
if (check_stack_overrun(thd, STACK_MIN_SIZE, NULL))
|
||||
{
|
||||
*cond_value= Item::COND_FALSE;
|
||||
return (COND*) 0; // Fatal error flag is set!
|
||||
}
|
||||
|
||||
if (and_level)
|
||||
{
|
||||
/*
|
||||
@@ -28977,15 +28988,86 @@ static bool setup_sum_funcs(THD *thd, Item_sum **func_ptr)
|
||||
}
|
||||
|
||||
|
||||
static bool prepare_sum_aggregators(THD *thd,Item_sum **func_ptr,
|
||||
bool need_distinct)
|
||||
/*
|
||||
@brief
|
||||
Setup aggregate functions.
|
||||
|
||||
@param thd Thread descriptor
|
||||
@param func_ptr Array of pointers to aggregate functions
|
||||
@param need_distinct FALSE means that the table access method already
|
||||
guarantees that arguments of all aggregate functions
|
||||
will be unique. (This is the case for Loose Scan)
|
||||
TRUE - Otherwise.
|
||||
@return
|
||||
false Ok
|
||||
true Error
|
||||
*/
|
||||
|
||||
bool JOIN::prepare_sum_aggregators(THD *thd, Item_sum **func_ptr,
|
||||
bool need_distinct)
|
||||
{
|
||||
Item_sum *func;
|
||||
DBUG_ENTER("prepare_sum_aggregators");
|
||||
while ((func= *(func_ptr++)))
|
||||
{
|
||||
if (func->set_aggregator(thd,
|
||||
need_distinct && func->has_with_distinct() ?
|
||||
bool need_distinct_aggregator= need_distinct && func->has_with_distinct();
|
||||
if (need_distinct_aggregator && table_count - const_tables == 1)
|
||||
{
|
||||
/*
|
||||
We are doing setup for an aggregate with DISTINCT, like
|
||||
|
||||
SELECT agg_func(DISTINCT col1, col2 ...) FROM ...
|
||||
|
||||
In general case, agg_func will need to use Aggregator_distinct to
|
||||
remove duplicates from its arguments.
|
||||
We won't have to remove duplicates if we know the arguments are already
|
||||
unique. This is true when
|
||||
1. the join operation has only one non-const table (checked above)
|
||||
2. the argument list covers a PRIMARY or a UNIQUE index.
|
||||
|
||||
Example: here the values of t1.pk are unique:
|
||||
|
||||
SELECT agg_func(DISTINCT t1.pk, ...) FROM t1
|
||||
|
||||
and so the whole argument of agg_func is unique.
|
||||
*/
|
||||
List<Item> arg_fields;
|
||||
for (uint i= 0; i < func->argument_count(); i++)
|
||||
{
|
||||
if (func->arguments()[i]->real_item()->type() == Item::FIELD_ITEM)
|
||||
arg_fields.push_back(func->arguments()[i]);
|
||||
}
|
||||
|
||||
/*
|
||||
If the query has a GROUP BY, then it's sufficient that a unique
|
||||
key is covered by a concatenation of {argument_list, group_by_list}.
|
||||
|
||||
Example: Suppose t1 has PRIMARY KEY(pk1, pk2). Then:
|
||||
|
||||
SELECT agg_func(DISTINCT t1.pk1, ...) FROM t1 GROUP BY t1.pk2
|
||||
|
||||
Each GROUP BY group will have t1.pk2 fixed. Then, the values of t1.pk1
|
||||
will be unique, and no de-duplication will be needed.
|
||||
*/
|
||||
for (ORDER *group= group_list; group ; group= group->next)
|
||||
{
|
||||
if ((*group->item)->real_item()->type() == Item::FIELD_ITEM)
|
||||
arg_fields.push_back(*group->item);
|
||||
}
|
||||
|
||||
if (list_contains_unique_index(join_tab[const_tables].table,
|
||||
find_field_in_item_list,
|
||||
(void *) &arg_fields))
|
||||
need_distinct_aggregator= false;
|
||||
}
|
||||
Json_writer_object trace_wrapper(thd);
|
||||
Json_writer_object trace_aggr(thd, "prepare_sum_aggregators");
|
||||
trace_aggr.add("function", func);
|
||||
trace_aggr.add("aggregator_type",
|
||||
(need_distinct_aggregator ||
|
||||
func->uses_non_standard_aggregator_for_distinct()) ?
|
||||
"distinct" : "simple");
|
||||
if (func->set_aggregator(thd, need_distinct_aggregator ?
|
||||
Aggregator::DISTINCT_AGGREGATOR :
|
||||
Aggregator::SIMPLE_AGGREGATOR))
|
||||
DBUG_RETURN(TRUE);
|
||||
|
Reference in New Issue
Block a user