database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

sql_updatable_view_key replaced with updatable_views_with_limit

Browse Source 
now default behaviour do not prevent any updates of view.
Also updating VIEWs of queries without LIMIT clause will not be checked at all (there will not be even warning)
(changes according to discussion on last dev-conf)


mysql-test/r/view.result:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
mysql-test/t/view.test:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
sql/mysqld.cc:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
sql/set_var.cc:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
sql/sql_class.h:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
sql/sql_view.cc:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
sql/sql_view.h:
  sql_updatable_view_key replaced with updatable_views_with_limit, default behaviour changed
This commit is contained in:
unknown
2004-10-07 12:13:42 +03:00
parent 640fefffa7
commit 62ce24cf9c
7 changed files with 50 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
mysql-test/r/view.result
View File

@ -753,31 +753,28 @@ create table t1 (a int, b int, c int, primary key(a,b));
insert into t1 values (10,2,-1), (20,3,-2), (30,4,-3), (40,5,-4), (50,10,-5);
create view v1 (x,y) as select a, b from t1;
create view v2 (x,y) as select a, c from t1;
set sql_updatable_view_key=YES;
set updatable_views_with_limit=NO;
update v1 set x=x+1;
update v2 set x=x+1;
ERROR HY000: The target table v2 of the UPDATE is not updatable
set sql_updatable_view_key=LIMIT1;
update v1 set x=x+1;
update v2 set x=x+1;
Warnings:
Note 1355 View being updated does not have complete key of underlying table in it
update v1 set x=x+1 limit 1;
update v2 set x=x+1 limit 1;
ERROR HY000: The target table v2 of the UPDATE is not updatable
set sql_updatable_view_key=NO;
set updatable_views_with_limit=YES;
update v1 set x=x+1 limit 1;
update v2 set x=x+1 limit 1;
Warnings:
Note 1355 View being updated does not have complete key of underlying table in it
set sql_updatable_view_key=DEFAULT;
set updatable_views_with_limit=DEFAULT;
show variables like "updatable_views_with_limit";
Variable_name Value
updatable_views_with_limit YES
select * from t1;
a b c
16 2 -1
23 3 -2
33 4 -3
43 5 -4
53 10 -5
15 2 -1
22 3 -2
32 4 -3
42 5 -4
52 10 -5
drop table t1;
drop view v1,v2;
create table t1 (a int, b int, c int, primary key(a,b));

11
mysql-test/t/view.test
View File

@ -628,20 +628,17 @@ create table t1 (a int, b int, c int, primary key(a,b));
insert into t1 values (10,2,-1), (20,3,-2), (30,4,-3), (40,5,-4), (50,10,-5);
create view v1 (x,y) as select a, b from t1;
create view v2 (x,y) as select a, c from t1;
set sql_updatable_view_key=YES;
update v1 set x=x+1;
-- error 1288
update v2 set x=x+1;
set sql_updatable_view_key=LIMIT1;
set updatable_views_with_limit=NO;
update v1 set x=x+1;
update v2 set x=x+1;
update v1 set x=x+1 limit 1;
-- error 1288
update v2 set x=x+1 limit 1;
set sql_updatable_view_key=NO;
set updatable_views_with_limit=YES;
update v1 set x=x+1 limit 1;
update v2 set x=x+1 limit 1;
set sql_updatable_view_key=DEFAULT;
set updatable_views_with_limit=DEFAULT;
show variables like "updatable_views_with_limit";
select * from t1;
drop table t1;
drop view v1,v2;