database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

Fixed LP bug #669382.

Browse Source 
When probing into the hash table of a hashed join cache is performed
the key value should not constructed in the buffer used to build keys
in the hash tables. The constant parts of these keys copied only once,
so they should not be ever overwritten. Otherwise wrong results
can be produced by queries that employ hashed join buffers.
This commit is contained in:
Igor Babaev
2010-11-04 21:00:33 -07:00
parent 73898792da
commit 615d756721
4 changed files with 68 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sql/sql_join_cache.cc
View File

@@ -2500,6 +2500,9 @@ int JOIN_CACHE_HASHED::init()
if ((rc= JOIN_CACHE::init()))
DBUG_RETURN (rc);
if (!(key_buff= (uchar*) sql_alloc(key_length)))
DBUG_RETURN(1);
/* Take into account a reference to the next record in the key chain */
pack_length+= get_size_of_rec_offset();
pack_length_with_blob_ptrs+= get_size_of_rec_offset();
@@ -3300,9 +3303,9 @@ uchar *JOIN_CACHE_BNLH::get_matching_chain_by_join_key()
TABLE_REF *ref= &join_tab->ref;
KEY *keyinfo= table->key_info+ref->key;
/* Build the join key value out of the record in the record buffer */
key_copy(ref->key_buff, table->record[0], keyinfo, ref->key_length);
key_copy(key_buff, table->record[0], keyinfo, key_length);
/* Look for this key in the join buffer */
if (!key_search(ref->key_buff, ref->key_length, &key_ref_ptr))
if (!key_search(key_buff, key_length, &key_ref_ptr))
return 0;
return key_ref_ptr+get_size_of_key_offset();
}