database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Split item->flags into base_flags and with_flags

Browse Source 
This was done to simplify copying of with_* flags

Other things:
- Changed Flags to C++ enums, which enables gdb to print
  out bit values for the flags. This also enables compiler
  errors if one tries to manipulate a non existing bit in
  a variable.
- Added set_maybe_null() as a shortcut as setting the
  MAYBE_NULL flags was used in a LOT of places.
- Renamed PARAM flag to SP_VAR to ensure it's not confused with persistent
  statement parameters.
This commit is contained in:
Monty
2020-09-02 03:13:32 +03:00
committed by Sergei Golubchik
parent 7ca4e381f7
commit 6079b46d8d
37 changed files with 522 additions and 460 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sql/sql_type.cc
View File

@ -4792,7 +4792,8 @@ bool Type_handler_temporal_result::
continue; // No conversion.
if (ha->cmp_type() != TIME_RESULT)
{
func->flags|= ITEM_FLAG_MAYBE_NULL; // Conversion from non-temporal is not safe
// Conversion from non-temporal is not safe
func->set_maybe_null();
break;
}
timestamp_type tf= hf->mysql_timestamp_type();
@ -4843,7 +4844,7 @@ bool Type_handler_temporal_result::
DBUG_ASSERT(hf->field_type() == MYSQL_TYPE_DATETIME);
if (!(thd->variables.old_behavior & OLD_MODE_ZERO_DATE_TIME_CAST))
continue;
func->flags|= ITEM_FLAG_MAYBE_NULL;
func->set_maybe_null();
break;
}
return rc;
@ -4867,7 +4868,7 @@ bool Type_handler_date_common::
{
if (items[i]->type_handler()->cmp_type() != TIME_RESULT)
{
func->flags|= ITEM_FLAG_MAYBE_NULL;
func->set_maybe_null();
break;
}
}
@ -6749,7 +6750,7 @@ bool Type_handler::
item->arguments()[0]->time_precision(current_thd) :
item->decimals;
item->fix_attributes_temporal(MIN_TIME_WIDTH, dec);
item->flags|= ITEM_FLAG_MAYBE_NULL;
item->set_maybe_null();
return false;
}
@ -6758,7 +6759,7 @@ bool Type_handler::
Item_date_typecast_fix_length_and_dec(Item_date_typecast *item) const
{
item->fix_attributes_temporal(MAX_DATE_WIDTH, 0);
item->flags|= ITEM_FLAG_MAYBE_NULL;
item->set_maybe_null();
return false;
}
@ -6771,7 +6772,7 @@ bool Type_handler::
item->arguments()[0]->datetime_precision(current_thd) :
item->decimals;
item->fix_attributes_temporal(MAX_DATETIME_WIDTH, dec);
item->flags|= ITEM_FLAG_MAYBE_NULL;
item->set_maybe_null();
return false;
}