From 60289fba0ba697e2bbab6136e7840216bea0633d Mon Sep 17 00:00:00 2001
From: unknown <kent@mysql.com/kent-amd64.(none)>
Date: Thu, 5 Apr 2007 08:36:56 +0200
Subject: [PATCH] zlib.m4:   Only require the more recent zlibCompileFlags()
 when   building the server, client zlib don't need it. Makefile.am:   Always
 build the bundled zlib static only configure.in:   Look for dlopen() even if
 --with-mysqld-ldflags constains "-static",   as this is not the same as the
 flag to "ld", it just informs   "libtool" to link static with libraries
 created part of the build,   even if there exists shared versions.
 make_binary_distribution.sh:   Real "mysqlmanager" executable might be in
 ".libs"

configure.in:
  Look for dlopen() even if --with-mysqld-ldflags constains "-static",
  as this is not the same as the flag to "ld", it just informs
  "libtool" to link static with libraries created part of the build,
  even if there exists shared versions.
config/ac-macros/zlib.m4:
  Only require the more recent zlibCompileFlags() when
  building the server, client zlib don't need it.
scripts/make_binary_distribution.sh:
  Real "mysqlmanager" executable might be in ".libs"
zlib/Makefile.am:
  Always build the bundled zlib static only
---
 config/ac-macros/zlib.m4            | 13 +++++++++++--
 configure.in                        |  4 ++--
 scripts/make_binary_distribution.sh |  8 +++++++-
 zlib/Makefile.am                    |  3 ++-
 4 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/config/ac-macros/zlib.m4 b/config/ac-macros/zlib.m4
index a01d13937ff..74de715e424 100644
--- a/config/ac-macros/zlib.m4
+++ b/config/ac-macros/zlib.m4
@@ -10,16 +10,25 @@ AC_SUBST([zlib_dir])
 mysql_cv_compress="yes"
 ])
 
-dnl Auxiliary macro to check for zlib at given path
+dnl Auxiliary macro to check for zlib at given path.
+dnl We are strict with the server, as "archive" engine
+dnl needs zlibCompileFlags(), but for client only we
+dnl are less strict, and take the zlib we find.
 
 AC_DEFUN([MYSQL_CHECK_ZLIB_DIR], [
 save_CPPFLAGS="$CPPFLAGS"
 save_LIBS="$LIBS"
 CPPFLAGS="$ZLIB_INCLUDES $CPPFLAGS"
 LIBS="$LIBS $ZLIB_LIBS"
+if test X"$with_server" = Xno
+then
+  zlibsym=zlibVersion
+else
+  zlibsym=zlibCompileFlags
+fi
 AC_CACHE_VAL([mysql_cv_compress],
   [AC_TRY_LINK([#include <zlib.h>],
-    [return zlibCompileFlags();],
+    [return $zlibsym();],
     [mysql_cv_compress="yes"
     AC_MSG_RESULT([ok])],
     [mysql_cv_compress="no"])
diff --git a/configure.in b/configure.in
index 9b0505a594f..bcf561c02ef 100644
--- a/configure.in
+++ b/configure.in
@@ -1601,9 +1601,9 @@ fi
 # dlopen, dlerror
 case "$with_mysqld_ldflags " in
 
-  *"-static "*)
+  *"-all-static "*)
     # No need to check for dlopen when mysqld is linked with
-    # -all-static or -static as it won't be able to load any functions.
+    # -all-static as it won't be able to load any functions.
     # NOTE! It would be better if it was possible to test if dlopen
     # can be used, but a good way to test it couldn't be found
 
diff --git a/scripts/make_binary_distribution.sh b/scripts/make_binary_distribution.sh
index 7d7918975f2..e8bf39bd016 100644
--- a/scripts/make_binary_distribution.sh
+++ b/scripts/make_binary_distribution.sh
@@ -115,7 +115,12 @@ if [ $BASE_SYSTEM != "netware" ] ; then
  chmod o-rwx $BASE/data $BASE/data/*
 fi
 
-# Copy files if they exists, warn for those that don't
+# Copy files if they exists, warn for those that don't.
+# Note that when listing files to copy, we might list the file name
+# twice, once in the directory location where it is build, and a
+# second time in the ".libs" location. In the case the firs one
+# is a wrapper script, the second one will overwrite it with the
+# binary file.
 copyfileto()
 {
   destdir=$1
@@ -165,6 +170,7 @@ if [ $BASE_SYSTEM = "netware" ] ; then
 # For all other platforms:
 else
   BIN_FILES="$BIN_FILES \
+    server-tools/instance-manager/.libs/mysqlmanager \
     client/mysqltestmanagerc \
     client/mysqltestmanager-pwgen tools/mysqltestmanager \
     client/.libs/mysql client/.libs/mysqlshow client/.libs/mysqladmin \
diff --git a/zlib/Makefile.am b/zlib/Makefile.am
index c40c922851e..f5741a782fb 100644
--- a/zlib/Makefile.am
+++ b/zlib/Makefile.am
@@ -21,7 +21,8 @@ LIBS= $(NON_THREADED_LIBS)
 
 pkglib_LTLIBRARIES=libz.la
 
-libz_la_LDFLAGS= -version-info 3:3:2
+# We are never interested in a shared version
+libz_la_LDFLAGS= -static
 
 noinst_HEADERS= crc32.h deflate.h inffast.h inffixed.h inflate.h \
 		inftrees.h trees.h zconf.h zlib.h zutil.h