database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-09 22:24:09 +03:00
Code Activity

MDEV-8464 : ALTER VIEW not replicated in some cases

Browse Source 
(Additional fix in 10.0-galera branch)
THD's lex->definer initially holds "*current_user" for
CURRENT_USER(). Use get_current_user() to get the real
current user.
This commit is contained in:
Nirbhay Choubey
2015-08-14 02:46:32 -04:00
parent 52f1543ef1
commit 5cf737c07a
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
sql/wsrep_mysqld.cc
View File

@@ -1130,7 +1130,13 @@ create_view_query(THD *thd, uchar** buf, size_t* buf_len)
buff.append(command[thd->lex->create_view_mode].str, buff.append(command[thd->lex->create_view_mode].str,
command[thd->lex->create_view_mode].length); command[thd->lex->create_view_mode].length);
if (!lex->definer) LEX_USER *definer;
if (lex->definer)
{
definer= get_current_user(thd, lex->definer);
}
else
{ {
/* /*
DEFINER-clause is missing; we have to create default definer in DEFINER-clause is missing; we have to create default definer in
@@ -1138,16 +1144,19 @@ create_view_query(THD *thd, uchar** buf, size_t* buf_len)
If this is an ALTER VIEW then the current user should be set as If this is an ALTER VIEW then the current user should be set as
the definer. the definer.
*/ */
definer= create_default_definer(thd, false);
if (!(lex->definer= create_default_definer(thd, false)))
{
WSREP_WARN("view default definer issue");
} }
if (definer)
{
views->definer.user = definer->user;
views->definer.host = definer->host;
} else {
WSREP_ERROR("Failed to get DEFINER for VIEW.");
return 1;
} }
views->algorithm = lex->create_view_algorithm; views->algorithm = lex->create_view_algorithm;
views->definer.user = lex->definer->user;
views->definer.host = lex->definer->host;
views->view_suid = lex->create_view_suid; views->view_suid = lex->create_view_suid;
views->with_check = lex->create_view_check; views->with_check = lex->create_view_check;