database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-23941: strings/json_lib.c:893:12: style: Suspicious condition

Browse Source 
The characters parsed are always ascii characters, hence one byte. This
means that the code did not have "incorrect" logic because the boolean
condition, if true, would also evaluate to the value of 1.

The condition however is semantically wrong, assuming a length is equal
to the condition outcome. Change paranthesis to make it also read
according to the intent.
This commit is contained in:
Vicențiu Ciorbaru
2020-10-12 13:38:59 +03:00
parent 8894dae1df
commit 5a9df1550f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
strings/json_lib.c
View File

@ -890,7 +890,7 @@ int json_read_keyname_chr(json_engine_t *j)
case S_QUOTE: case S_QUOTE:
for (;;) /* Skip spaces until ':'. */ for (;;) /* Skip spaces until ':'. */
{ {
if ((c_len= json_next_char(&j->s) > 0)) if ((c_len= json_next_char(&j->s)) > 0)
{ {
if (j->s.c_next == ':') if (j->s.c_next == ':')
{ {