mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
Changing field::field_name and Item::name to LEX_CSTRING
Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char*) to (char*) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."*' is not anymore same as table_name.* - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)
This commit is contained in:
@@ -70,19 +70,19 @@ int prepare_schema_table(THD *thd, LEX *lex, Table_ident *table_ident,
|
||||
enum enum_schema_tables schema_table_idx);
|
||||
void get_default_definer(THD *thd, LEX_USER *definer, bool role);
|
||||
LEX_USER *create_default_definer(THD *thd, bool role);
|
||||
LEX_USER *create_definer(THD *thd, LEX_STRING *user_name, LEX_STRING *host_name);
|
||||
LEX_USER *create_definer(THD *thd, LEX_CSTRING *user_name, LEX_CSTRING *host_name);
|
||||
LEX_USER *get_current_user(THD *thd, LEX_USER *user, bool lock=true);
|
||||
bool sp_process_definer(THD *thd);
|
||||
bool check_string_byte_length(LEX_STRING *str, uint err_msg,
|
||||
bool check_string_byte_length(LEX_CSTRING *str, uint err_msg,
|
||||
uint max_byte_length);
|
||||
bool check_string_char_length(LEX_STRING *str, uint err_msg,
|
||||
bool check_string_char_length(LEX_CSTRING *str, uint err_msg,
|
||||
uint max_char_length, CHARSET_INFO *cs,
|
||||
bool no_error);
|
||||
bool check_ident_length(LEX_STRING *ident);
|
||||
bool check_ident_length(LEX_CSTRING *ident);
|
||||
CHARSET_INFO* merge_charset_and_collation(CHARSET_INFO *cs, CHARSET_INFO *cl);
|
||||
CHARSET_INFO *find_bin_collation(CHARSET_INFO *cs);
|
||||
bool check_host_name(LEX_STRING *str);
|
||||
bool check_identifier_name(LEX_STRING *str, uint max_char_length,
|
||||
bool check_host_name(LEX_CSTRING *str);
|
||||
bool check_identifier_name(LEX_CSTRING *str, uint max_char_length,
|
||||
uint err_code, const char *param_for_err_msg);
|
||||
bool mysql_test_parse_for_slave(THD *thd,char *inBuf,uint length);
|
||||
bool sqlcom_can_generate_row_events(const THD *thd);
|
||||
@@ -136,12 +136,12 @@ extern const LEX_STRING command_name[];
|
||||
extern uint server_command_flags[];
|
||||
|
||||
/* Inline functions */
|
||||
inline bool check_identifier_name(LEX_STRING *str, uint err_code)
|
||||
inline bool check_identifier_name(LEX_CSTRING *str, uint err_code)
|
||||
{
|
||||
return check_identifier_name(str, NAME_CHAR_LEN, err_code, "");
|
||||
}
|
||||
|
||||
inline bool check_identifier_name(LEX_STRING *str)
|
||||
inline bool check_identifier_name(LEX_CSTRING *str)
|
||||
{
|
||||
return check_identifier_name(str, NAME_CHAR_LEN, 0, "");
|
||||
}
|
||||
@@ -150,7 +150,8 @@ inline bool check_identifier_name(LEX_STRING *str)
|
||||
bool check_one_table_access(THD *thd, ulong privilege, TABLE_LIST *tables);
|
||||
bool check_single_table_access(THD *thd, ulong privilege,
|
||||
TABLE_LIST *tables, bool no_errors);
|
||||
bool check_routine_access(THD *thd,ulong want_access,char *db,char *name,
|
||||
bool check_routine_access(THD *thd,ulong want_access,const char *db,
|
||||
const char *name,
|
||||
bool is_proc, bool no_errors);
|
||||
bool check_some_access(THD *thd, ulong want_access, TABLE_LIST *table);
|
||||
bool check_some_routine_access(THD *thd, const char *db, const char *name, bool is_proc);
|
||||
@@ -164,8 +165,8 @@ inline bool check_one_table_access(THD *thd, ulong privilege, TABLE_LIST *tables
|
||||
inline bool check_single_table_access(THD *thd, ulong privilege,
|
||||
TABLE_LIST *tables, bool no_errors)
|
||||
{ return false; }
|
||||
inline bool check_routine_access(THD *thd,ulong want_access,char *db,
|
||||
char *name, bool is_proc, bool no_errors)
|
||||
inline bool check_routine_access(THD *thd,ulong want_access, const char *db,
|
||||
const char *name, bool is_proc, bool no_errors)
|
||||
{ return false; }
|
||||
inline bool check_some_access(THD *thd, ulong want_access, TABLE_LIST *table)
|
||||
{
|
||||
|
Reference in New Issue
Block a user