database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-14 13:41:20 +03:00
Code Activity

cleanup: Field_set::empty_set_string

Browse Source 
in particular, it overwrites pre-allocated buffer in val_buffer,
so following val_buffer->append()'s cause totally unnecessary
mallocs.
This commit is contained in:
Sergei Golubchik
2020-10-02 00:03:20 +02:00
parent 3648b333c7
commit 59b51e6aa7
2 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sql/field.cc
View File

@ -9381,16 +9381,6 @@ String *Field_set::val_str(String *val_buffer,
ulonglong tmp=(ulonglong) Field_enum::val_int();
uint bitnr=0;
/*
Some callers expect *val_buffer to contain the result,
so we assign to it, rather than doing 'return &empty_set_string.
*/
*val_buffer= empty_set_string;
if (tmp == 0)
{
return val_buffer;
}
val_buffer->set_charset(field_charset());
val_buffer->length(0);