database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Bug #15868071 USING SET GLOBAL SQL_LOG_BIN SHOULD NOT BE ALLOWED

Browse Source 
Normally, SET SESSION SQL_LOG_BIN is used by DBAs to run a
non-conflicting command locally only, ensuring it does not
get replicated.
Setting GLOBAL SQL_LOG_BIN would not require all sessions to
disconnect. When SQL_LOG_BIN is changed globally, it does not
immediately take effect for any sessions. It takes effect by
becoming the session-level default inherited at the start of
each new session, and this setting is kept and cached for the
duration of that session. Setting it intentionally is unlikely
to have a useful effect under any circumstance; setting it
unintentionally, such as while intending to use SET [SESSION]
is potentially disastrous. Accidentally using SET GLOBAL
SQL_LOG_BIN will not show an immediate effect to the user,
instead not having the desired session-level effect, and thus
causing other potential problems with local-only maintenance
being binlogged and executed on slaves; And transactions from
new sessions (after SQL_LOG_BIN is changed globally) are not
binlogged and replicated, which would result in irrecoverable
or difficult data loss.
This is the regular GLOBAL variables way to work, but in
replication context it does not look right on a working server
(with connected sessions) 'set global sql_log_bin' and none of
that connections is affected. Unexperienced DBA after noticing
that the command did "nothing" will change the session var and
most probably won't unset the global var, causing new sessions
to not be binlog.
Setting GLOBAL SQL_LOG_BIN allows DBA to stop binlogging on all
new sessions, which can be used to make a server "replication
read-only" without restarting the server. But this has such big
requirements, stop all existing connections, that it is more
likely to make a mess, it is too risky to allow the GLOBAL variable.

The statement 'SET GLOBAL SQL_LOG_BIN=N' will produce an error
in 5.5, 5.6 and 5.7. Reading the GLOBAL SQL_LOG_BIN will produce
a deprecation warning in 5.7.
This commit is contained in:
Bill Qu
2014-09-24 09:44:48 +08:00
parent abb9945965
commit 5693b1e4a4
6 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mysql-test/suite/binlog/r/binlog_switch_inside_trans.result
View File

@ -1,6 +1,5 @@
set @save_binlog_format= @@global.binlog_format; set @save_binlog_format= @@global.binlog_format;
set @save_binlog_dirct= @@global.binlog_direct_non_transactional_updates; set @save_binlog_dirct= @@global.binlog_direct_non_transactional_updates;
set @save_sql_log_bin= @@global.sql_log_bin;
create table t1 (a int) engine= myisam; create table t1 (a int) engine= myisam;
create table t2 (a int) engine= innodb; create table t2 (a int) engine= innodb;
SELECT @@session.binlog_format; SELECT @@session.binlog_format;
@ -129,7 +128,7 @@ commit;
begin; begin;
insert into t2 values (5); insert into t2 values (5);
# Test that the global variable 'binlog_format' and # Test that the global variable 'binlog_format' and
# 'binlog_direct_non_transactional_updates' and 'sql_log_bin' are # 'binlog_direct_non_transactional_updates' are
# writable inside a transaction. # writable inside a transaction.
# Current session values are ROW, FALSE, TRUE respectively. # Current session values are ROW, FALSE, TRUE respectively.
SELECT @@global.binlog_format; SELECT @@global.binlog_format;
@ -137,20 +136,15 @@ SELECT @@global.binlog_format;
ROW ROW
set @@global.binlog_format= statement; set @@global.binlog_format= statement;
set @@global.binlog_direct_non_transactional_updates= TRUE; set @@global.binlog_direct_non_transactional_updates= TRUE;
set @@global.sql_log_bin= FALSE;
SELECT @@global.binlog_format; SELECT @@global.binlog_format;
@@global.binlog_format @@global.binlog_format
STATEMENT STATEMENT
SELECT @@global.binlog_direct_non_transactional_updates; SELECT @@global.binlog_direct_non_transactional_updates;
@@global.binlog_direct_non_transactional_updates @@global.binlog_direct_non_transactional_updates
1 1
SELECT @@global.sql_log_bin;
@@global.sql_log_bin
0
commit; commit;
set @@global.binlog_format= @save_binlog_format; set @@global.binlog_format= @save_binlog_format;
set @@global.binlog_direct_non_transactional_updates= @save_binlog_dirct; set @@global.binlog_direct_non_transactional_updates= @save_binlog_dirct;
set @@global.sql_log_bin= @save_sql_log_bin;
create table t3(a int, b int) engine= innodb; create table t3(a int, b int) engine= innodb;
create table t4(a int) engine= innodb; create table t4(a int) engine= innodb;
create table t5(a int) engine= innodb; create table t5(a int) engine= innodb;

2
mysql-test/suite/binlog/t/binlog_grant.test
View File

@ -15,7 +15,7 @@ show grants for mysqltest_1@localhost;
connect (plain,localhost,mysqltest_1,,test); connect (plain,localhost,mysqltest_1,,test);
connect (root,localhost,root,,test); connect (root,localhost,root,,test);
# Testing setting both session and global SQL_LOG_BIN variable both as # Testing setting session SQL_LOG_BIN variable both as
# root and as plain user. # root and as plain user.
--echo **** Variable SQL_LOG_BIN **** --echo **** Variable SQL_LOG_BIN ****

6
mysql-test/suite/binlog/t/binlog_switch_inside_trans.test
View File

@ -10,7 +10,6 @@ source include/have_binlog_format_row.inc;
set @save_binlog_format= @@global.binlog_format; set @save_binlog_format= @@global.binlog_format;
set @save_binlog_dirct= @@global.binlog_direct_non_transactional_updates; set @save_binlog_dirct= @@global.binlog_direct_non_transactional_updates;
set @save_sql_log_bin= @@global.sql_log_bin;
create table t1 (a int) engine= myisam; create table t1 (a int) engine= myisam;
create table t2 (a int) engine= innodb; create table t2 (a int) engine= innodb;
@ -117,21 +116,18 @@ commit;
begin; begin;
insert into t2 values (5); insert into t2 values (5);
--echo # Test that the global variable 'binlog_format' and --echo # Test that the global variable 'binlog_format' and
--echo # 'binlog_direct_non_transactional_updates' and 'sql_log_bin' are --echo # 'binlog_direct_non_transactional_updates' are
--echo # writable inside a transaction. --echo # writable inside a transaction.
--echo # Current session values are ROW, FALSE, TRUE respectively. --echo # Current session values are ROW, FALSE, TRUE respectively.
SELECT @@global.binlog_format; SELECT @@global.binlog_format;
set @@global.binlog_format= statement; set @@global.binlog_format= statement;
set @@global.binlog_direct_non_transactional_updates= TRUE; set @@global.binlog_direct_non_transactional_updates= TRUE;
set @@global.sql_log_bin= FALSE;
SELECT @@global.binlog_format; SELECT @@global.binlog_format;
SELECT @@global.binlog_direct_non_transactional_updates; SELECT @@global.binlog_direct_non_transactional_updates;
SELECT @@global.sql_log_bin;
commit; commit;
set @@global.binlog_format= @save_binlog_format; set @@global.binlog_format= @save_binlog_format;
set @@global.binlog_direct_non_transactional_updates= @save_binlog_dirct; set @@global.binlog_direct_non_transactional_updates= @save_binlog_dirct;
set @@global.sql_log_bin= @save_sql_log_bin;
create table t3(a int, b int) engine= innodb; create table t3(a int, b int) engine= innodb;
create table t4(a int) engine= innodb; create table t4(a int) engine= innodb;

9
mysql-test/suite/sys_vars/r/sql_log_bin_basic.result
View File

@ -57,11 +57,16 @@ ERROR 42000: Variable 'sql_log_bin' can't be set to the value of '
SET @@session.sql_log_bin = NO; SET @@session.sql_log_bin = NO;
ERROR 42000: Variable 'sql_log_bin' can't be set to the value of 'NO' ERROR 42000: Variable 'sql_log_bin' can't be set to the value of 'NO'
'#-------------------FN_DYNVARS_156_05----------------------------#' '#-------------------FN_DYNVARS_156_05----------------------------#'
SET @@global.sql_log_bin = 0;
SELECT @@global.sql_log_bin; SELECT @@global.sql_log_bin;
@@global.sql_log_bin @@global.sql_log_bin
0 1
SET @@global.sql_log_bin = 0;
ERROR 42000: Variable 'sql_log_bin' can't be set to the value of '0'
SELECT @@global.sql_log_bin;
@@global.sql_log_bin
1
SET @@global.sql_log_bin = 1; SET @@global.sql_log_bin = 1;
ERROR 42000: Variable 'sql_log_bin' can't be set to the value of '1'
'#----------------------FN_DYNVARS_156_06------------------------#' '#----------------------FN_DYNVARS_156_06------------------------#'
SELECT count(VARIABLE_VALUE) FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='sql_log_bin'; SELECT count(VARIABLE_VALUE) FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES WHERE VARIABLE_NAME='sql_log_bin';
count(VARIABLE_VALUE) count(VARIABLE_VALUE)

6
mysql-test/suite/sys_vars/t/sql_log_bin_basic.test
View File

@ -109,11 +109,15 @@ SET @@session.sql_log_bin = NO;
--echo '#-------------------FN_DYNVARS_156_05----------------------------#' --echo '#-------------------FN_DYNVARS_156_05----------------------------#'
########################################################################### ###########################################################################
# Test if accessing global sql_log_bin gives error # # Test if setting global sql_log_bin gives error, #
# and there is no error on reading it. #
########################################################################### ###########################################################################
SELECT @@global.sql_log_bin;
--Error ER_WRONG_VALUE_FOR_VAR
SET @@global.sql_log_bin = 0; SET @@global.sql_log_bin = 0;
SELECT @@global.sql_log_bin; SELECT @@global.sql_log_bin;
--Error ER_WRONG_VALUE_FOR_VAR
SET @@global.sql_log_bin = 1; SET @@global.sql_log_bin = 1;
--echo '#----------------------FN_DYNVARS_156_06------------------------#' --echo '#----------------------FN_DYNVARS_156_06------------------------#'

22
sql/sys_vars.cc
View File

@ -2447,13 +2447,13 @@ static Sys_var_bit Sys_log_off(
static bool fix_sql_log_bin_after_update(sys_var *self, THD *thd, static bool fix_sql_log_bin_after_update(sys_var *self, THD *thd,
enum_var_type type) enum_var_type type)
{ {
if (type == OPT_SESSION) DBUG_ASSERT(type == OPT_SESSION);
{
if (thd->variables.sql_log_bin) if (thd->variables.sql_log_bin)
thd->variables.option_bits |= OPTION_BIN_LOG; thd->variables.option_bits |= OPTION_BIN_LOG;
else else
thd->variables.option_bits &= ~OPTION_BIN_LOG; thd->variables.option_bits &= ~OPTION_BIN_LOG;
}
return FALSE; return FALSE;
} }
@ -2475,7 +2475,7 @@ static bool check_sql_log_bin(sys_var *self, THD *thd, set_var *var)
return TRUE; return TRUE;
if (var->type == OPT_GLOBAL) if (var->type == OPT_GLOBAL)
return FALSE; return TRUE;
/* If in a stored function/trigger, it's too late to change sql_log_bin. */ /* If in a stored function/trigger, it's too late to change sql_log_bin. */
if (thd->in_sub_stmt) if (thd->in_sub_stmt)
@ -2494,9 +2494,9 @@ static bool check_sql_log_bin(sys_var *self, THD *thd, set_var *var)
} }
static Sys_var_mybool Sys_log_binlog( static Sys_var_mybool Sys_log_binlog(
"sql_log_bin", "sql_log_bin", "sql_log_bin", "Controls whether logging to the binary log is done",
SESSION_VAR(sql_log_bin), NO_CMD_LINE, SESSION_VAR(sql_log_bin), NO_CMD_LINE, DEFAULT(TRUE),
DEFAULT(TRUE), NO_MUTEX_GUARD, NOT_IN_BINLOG, ON_CHECK(check_sql_log_bin), NO_MUTEX_GUARD, NOT_IN_BINLOG, ON_CHECK(check_sql_log_bin),
ON_UPDATE(fix_sql_log_bin_after_update)); ON_UPDATE(fix_sql_log_bin_after_update));
static Sys_var_bit Sys_sql_warnings( static Sys_var_bit Sys_sql_warnings(