From 56113a7c12d247d7b5c9cf72cb11cd08d83c356b Mon Sep 17 00:00:00 2001 From: unknown Date: Wed, 18 Apr 2007 14:24:09 +0200 Subject: [PATCH] mysql-test/mysql-test-run.pl set --language correctly even for --help (to have full plugin help) mysql-test/lib/mtr_cases.pl more robust check for innodb mysql-test/lib/mtr_cases.pl: more robust check for innodb mysql-test/mysql-test-run.pl: set --language correctly even for --help (to have full plugin help) --- mysql-test/lib/mtr_cases.pl | 2 +- mysql-test/mysql-test-run.pl | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/mysql-test/lib/mtr_cases.pl b/mysql-test/lib/mtr_cases.pl index 28c78fbffeb..d7aa4445551 100644 --- a/mysql-test/lib/mtr_cases.pl +++ b/mysql-test/lib/mtr_cases.pl @@ -580,7 +580,7 @@ sub collect_one_test_case($$$$$$$) { if ( $tinfo->{'innodb_test'} ) { # This is a test that need innodb - if ( $::mysqld_variables{'innodb'} eq "FALSE" ) + if ( $::mysqld_variables{'innodb'} ne "TRUE" ) { # innodb is not supported, skip it $tinfo->{'skip'}= 1; diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl index 4ed1686a121..4306a5ade77 100755 --- a/mysql-test/mysql-test-run.pl +++ b/mysql-test/mysql-test-run.pl @@ -58,7 +58,7 @@ $Devel::Trace::TRACE= 0; # Don't trace boring init stuff use File::Path; use File::Basename; use File::Copy; -use File::Temp qw / tempdir /; +use File::Temp qw /tempdir/; use Cwd; use Getopt::Long; use Sys::Hostname; @@ -113,6 +113,7 @@ our $glob_basedir; our $path_charsetsdir; our $path_client_bindir; +our $path_share; our $path_language; our $path_timefile; our $path_snapshot; @@ -704,6 +705,15 @@ sub command_line_setup () { "$glob_basedir/client", "$glob_basedir/bin"); + # Look for language files and charsetsdir, use same share + $path_share= mtr_path_exists("$glob_basedir/share/mysql", + "$glob_basedir/sql/share", + "$glob_basedir/share"); + + $path_language= mtr_path_exists("$path_share/english"); + $path_charsetsdir= mtr_path_exists("$path_share/charsets"); + + if (!$opt_extern) { $exe_mysqld= mtr_exe_exists (vs_config_dirs('sql', 'mysqld'), @@ -1351,7 +1361,7 @@ sub collect_mysqld_features () { # --no-defaults and --skip-grant-tables are to avoid loading # system-wide configs and plugins # - my $list= `$exe_mysqld --no-defaults --skip-grant-tables --verbose --help`; + my $list= `$exe_mysqld --no-defaults --language=$path_language --skip-grant-tables --verbose --help`; foreach my $line (split('\n', $list)) { @@ -1514,14 +1524,6 @@ sub executable_setup () { } } - # Look for language files and charsetsdir, use same share - my $path_share= mtr_path_exists("$glob_basedir/share/mysql", - "$glob_basedir/sql/share", - "$glob_basedir/share"); - - $path_language= mtr_path_exists("$path_share/english"); - $path_charsetsdir= mtr_path_exists("$path_share/charsets"); - # Look for my_print_defaults $exe_my_print_defaults= mtr_exe_exists(vs_config_dirs('extra', 'my_print_defaults'),