database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-10-22 19:52:58 +03:00
Code Activity

Bug#21620 ALTER TABLE affects other columns

Browse Source 
Problem: for character sets having mbmaxlen==2,
  any ALTER TABLE changed TEXT column type to MEDIUMTEXT,
  due to wrong "internal length to create length" formula.
  Fix: removing rounding code introduced in early 4.1 time,
  which is not correct anymore.
This commit is contained in:
bar@mysql.com/bar.intranet.mysql.r18.ru
2006-09-29 16:24:11 +05:00
parent 15887b602b
commit 53dea28352
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mysql-test/r/ctype_gbk.result
View File

@@ -168,3 +168,13 @@ DROP TABLE t1;
select hex(convert(_gbk 0xA14041 using ucs2)); select hex(convert(_gbk 0xA14041 using ucs2));
hex(convert(_gbk 0xA14041 using ucs2)) hex(convert(_gbk 0xA14041 using ucs2))
003F0041 003F0041
create table t1 (c1 text not null, c2 text not null) character set gbk;
alter table t1 change c1 c1 mediumtext character set gbk not null;
show create table t1;
Table Create Table
t1 CREATE TABLE `t1` (
`c1` mediumtext NOT NULL,
`c2` text NOT NULL
) ENGINE=MyISAM DEFAULT CHARSET=gbk
drop table t1;
End of 5.0 tests

10
mysql-test/t/ctype_gbk.test
View File

@@ -42,3 +42,13 @@ DROP TABLE t1;
select hex(convert(_gbk 0xA14041 using ucs2)); select hex(convert(_gbk 0xA14041 using ucs2));
# End of 4.1 tests # End of 4.1 tests
#
# Bug#21620 ALTER TABLE affects other columns
#
create table t1 (c1 text not null, c2 text not null) character set gbk;
alter table t1 change c1 c1 mediumtext character set gbk not null;
show create table t1;
drop table t1;
--echo End of 5.0 tests

2
sql/field.cc
View File

@@ -8877,7 +8877,7 @@ create_field::create_field(Field *old_field,Field *orig_field)
case 3: sql_type= FIELD_TYPE_MEDIUM_BLOB; break; case 3: sql_type= FIELD_TYPE_MEDIUM_BLOB; break;
default: sql_type= FIELD_TYPE_LONG_BLOB; break; default: sql_type= FIELD_TYPE_LONG_BLOB; break;
} }
length=(length+charset->mbmaxlen-1) / charset->mbmaxlen; length/= charset->mbmaxlen;
key_length/= charset->mbmaxlen; key_length/= charset->mbmaxlen;
break; break;
case MYSQL_TYPE_STRING: case MYSQL_TYPE_STRING: