database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Fix return code from check-warnings to indicate if test failed or not.

Browse Source 
No more string matching


mysql-test/include/check-warnings.test:
  Check return value from check_warnings and call skip if ok
mysql-test/include/mtr_check.sql:
  Improve readability
mysql-test/include/mtr_warnings.sql:
  Add out parameter for result.
  Increase the max_allowed_packet variable so the load_file works
  even if the server is started with low such value
This commit is contained in:
unknown
2008-04-09 14:38:42 +02:00
parent fc0de68e00
commit 5242048883
4 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mysql-test/include/check-warnings.test
View File

@ -4,5 +4,9 @@
# for unexpected warnings found in the servers error log # for unexpected warnings found in the servers error log
# #
--disable_query_log --disable_query_log
call mtr.check_warnings(); call mtr.check_warnings(@result);
if (`select @result = 0`){
skip OK;
}
echo Found warnings;
--enable_query_log --enable_query_log

2
mysql-test/include/mtr_check.sql
View File

@ -19,7 +19,7 @@ BEGIN
SELECT * FROM INFORMATION_SCHEMA.SCHEMATA; SELECT * FROM INFORMATION_SCHEMA.SCHEMATA;
-- The test database should not contain any tables -- The test database should not contain any tables
SELECT table_name FROM INFORMATION_SCHEMA.TABLES SELECT table_name AS tables_in_test FROM INFORMATION_SCHEMA.TABLES
WHERE table_schema='test'; WHERE table_schema='test';
-- Show "mysql" database, tables and columns -- Show "mysql" database, tables and columns

8
mysql-test/include/mtr_warnings.sql
View File

@ -208,7 +208,7 @@ INSERT INTO global_supressions VALUES
-- Procedure that uses the above created tables to check -- Procedure that uses the above created tables to check
-- the servers error log for warnings -- the servers error log for warnings
-- --
CREATE DEFINER=root@localhost PROCEDURE check_warnings() CREATE DEFINER=root@localhost PROCEDURE check_warnings(OUT result INT)
BEGIN BEGIN
-- Don't write these queries to binlog -- Don't write these queries to binlog
@ -225,6 +225,7 @@ BEGIN
FROM information_schema.global_variables FROM information_schema.global_variables
WHERE variable_name='LOG_ERROR'; WHERE variable_name='LOG_ERROR';
SET @@session.max_allowed_packet= 1024*1024*1024;
SET @text= load_file(@log_error); SET @text= load_file(@log_error);
-- select @text; -- select @text;
@ -269,8 +270,11 @@ BEGIN
SELECT line as log_error SELECT line as log_error
FROM suspect_lines WHERE supressed=0; FROM suspect_lines WHERE supressed=0;
SELECT * FROM test_supressions; SELECT * FROM test_supressions;
-- Return 2 -> check failed
SELECT 2 INTO result;
ELSE ELSE
SELECT "OK"; -- Return 0 -> OK
SELECT 0 INTO RESULT;
END IF; END IF;
-- Cleanup for next test -- Cleanup for next test

18
mysql-test/mysql-test-run.pl
View File

@ -2568,22 +2568,16 @@ sub run_check_warnings ($$) {
if ( $res == 0 ) if ( $res == 0 )
{ {
my $report= mtr_grab_file($errfile); my $report= mtr_grab_file($errfile);
if ($report ne "OK\nOK\n") # Log to var/log/warnings file
{ mtr_tofile("$opt_vardir/log/warnings",
# Log to var/log/warnings file
mtr_tofile("$opt_vardir/log/warnings",
$tname."\n", $tname."\n",
$report); $report);
$res= 1; $res= 1;
$tinfo->{'warnings'}.= $report; $tinfo->{'warnings'}.= $report;
}
} }
elsif ( $res == 62 ) elsif ( $res == 62 ) {
{ # Test case was ok and called "skip"
# One of the features needed to run check_warnings.test was not
# available, check skipped
$res= 0; $res= 0;
} }
elsif ( $res ) elsif ( $res )