database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-12-24 11:21:21 +03:00
Code Activity

BUG#25677 - With --skip-symbolic-links option on, DATA DIRECTORY

Browse Source 
clause is silently ignored

When symbolic links are disabled by command line option or
NO_DIR_IN_CREATE sql mode, CREATE TABLE silently ignores
DATA/INDEX DIRECTORY options.

With this fix a warning is issued when symbolic links are disabled.


mysql-test/r/symlink.result:
  A test case for BUG#25677.
mysql-test/t/symlink.test:
  A test case for BUG#25677.
sql/sql_parse.cc:
  Moved handling of situation when mysqld is compiled without
  HAVE_READLINK to mysql_create_table_no_lock().
sql/sql_table.cc:
  Issue a warning in case DATA/INDEX DIRECTORY is specified and:
  - server is compiled without HAVE_READLINK;
  - using symbolic links is disabled by command line option;
  - using symbolic links is disabled by NO_DIR_IN_CREATE sql mode.
This commit is contained in:
unknown
2007-12-07 17:40:42 +04:00
parent b9ecec8622
commit 510bda4bed
6 changed files with 105 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sql/sql_table.cc
View File

@@ -3437,8 +3437,18 @@ bool mysql_create_table_no_lock(THD *thd,
thd->proc_info="creating table";
create_info->table_existed= 0; // Mark that table is created
if (thd->variables.sql_mode & MODE_NO_DIR_IN_CREATE)
#ifdef HAVE_READLINK
if (!my_use_symdir || (thd->variables.sql_mode & MODE_NO_DIR_IN_CREATE))
#endif
{
if (create_info->data_file_name)
push_warning(thd, MYSQL_ERROR::WARN_LEVEL_WARN, 0,
"DATA DIRECTORY option ignored");
if (create_info->index_file_name)
push_warning(thd, MYSQL_ERROR::WARN_LEVEL_WARN, 0,
"INDEX DIRECTORY option ignored");
create_info->data_file_name= create_info->index_file_name= 0;
}
create_info->table_options=db_options;
path[path_length - reg_ext_length]= '\0'; // Remove .frm extension