database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-09-03 20:43:11 +03:00
Code Activity

MariaRocks port: Make SQL layer allow errors in start_consistent_snapshot().

Browse Source 
rocksdb.cons_snapshot_read_committed test used to crash.
This happened, because
- MyRocks produces an error when one attempts to do a START TRANSACTION
  WITH CONSISTENT SNAPSHOT with @@tx_isolation=REPEATABLE_READ
- MariaDB's SQL layer didn't assume that errors are possible inside
  hton->start_constistent_snapshot() call.
This commit is contained in:
Sergei Petrunia
2016-12-27 01:55:05 +03:00
parent 8f2d58b26b
commit 4faa9da81c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sql/sql_parse.cc
View File

@@ -5428,7 +5428,9 @@ end_with_restore_list:
(longlong) thd->thread_id);
goto error;
}
my_ok(thd);
/* MyRocks: hton->start_consistent_snapshot call may fail with an error */
if (!thd->is_error())
my_ok(thd);
break;
case SQLCOM_COMMIT:
{