database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

after-merge: simplify, fix a bug

Browse Source 
* simplify the code at default: label
* bugfix: flush the checksum for NULL fields
  (perfschema.checksum was failing)
* cleanup: put repeated code into a function
This commit is contained in:
Sergei Golubchik
2016-04-29 18:39:18 +02:00
parent aed1485b99
commit 4f1c81de28
1 changed files with 20 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
sql/sql_table.cc
View File

@ -9668,6 +9668,18 @@ bool mysql_recreate_table(THD *thd, TABLE_LIST *table_list, bool table_copy)
} }
static void flush_checksum(ha_checksum *row_crc, uchar **checksum_start,
size_t *checksum_length)
{
if (*checksum_start)
{
*row_crc= my_checksum(*row_crc, *checksum_start, *checksum_length);
*checksum_start= NULL;
*checksum_length= 0;
}
}
bool mysql_checksum_table(THD *thd, TABLE_LIST *tables, bool mysql_checksum_table(THD *thd, TABLE_LIST *tables,
HA_CHECK_OPT *check_opt) HA_CHECK_OPT *check_opt)
{ {
@ -9796,7 +9808,10 @@ bool mysql_checksum_table(THD *thd, TABLE_LIST *tables,
Field *f= t->field[i]; Field *f= t->field[i];
if (! thd->variables.old_mode && f->is_real_null(0)) if (! thd->variables.old_mode && f->is_real_null(0))
{
flush_checksum(&row_crc, &checksum_start, &checksum_length);
continue; continue;
}
/* /*
BLOB and VARCHAR have pointers in their field, we must convert BLOB and VARCHAR have pointers in their field, we must convert
to string; GEOMETRY is implemented on top of BLOB. to string; GEOMETRY is implemented on top of BLOB.
@ -9808,12 +9823,7 @@ bool mysql_checksum_table(THD *thd, TABLE_LIST *tables,
case MYSQL_TYPE_GEOMETRY: case MYSQL_TYPE_GEOMETRY:
case MYSQL_TYPE_BIT: case MYSQL_TYPE_BIT:
{ {
if (checksum_start) flush_checksum(&row_crc, &checksum_start, &checksum_length);
{
row_crc= my_checksum(row_crc, checksum_start, checksum_length);
checksum_start= NULL;
checksum_length= 0;
}
String tmp; String tmp;
f->val_str(&tmp); f->val_str(&tmp);
row_crc= my_checksum(row_crc, (uchar*) tmp.ptr(), row_crc= my_checksum(row_crc, (uchar*) tmp.ptr(),
@ -9821,29 +9831,14 @@ bool mysql_checksum_table(THD *thd, TABLE_LIST *tables,
break; break;
} }
default: default:
if (checksum_start) if (!checksum_start)
{
if (checksum_start + checksum_length == f->ptr)
{
checksum_length+= f->pack_length();
}
else
{
row_crc= my_checksum(row_crc, checksum_start, checksum_length);
checksum_start= f->ptr;
checksum_length= f->pack_length();
}
}
else
{
checksum_start= f->ptr; checksum_start= f->ptr;
checksum_length= f->pack_length(); DBUG_ASSERT(checksum_start + checksum_length == f->ptr);
} checksum_length+= f->pack_length();
break; break;
} }
} }
if (checksum_start) flush_checksum(&row_crc, &checksum_start, &checksum_length);
row_crc= my_checksum(row_crc, checksum_start, checksum_length);
crc+= row_crc; crc+= row_crc;
} }