diff --git a/mysql-test/r/func_gconcat.result b/mysql-test/r/func_gconcat.result index 221b311b1ce..09b6de796c4 100644 --- a/mysql-test/r/func_gconcat.result +++ b/mysql-test/r/func_gconcat.result @@ -458,7 +458,7 @@ create table t2 select group_concat(a) as a from t1; show create table t2; Table Create Table t2 CREATE TABLE `t2` ( - `a` longtext character set cp1250 + `a` varchar(400) character set cp1250 default NULL ) ENGINE=MyISAM DEFAULT CHARSET=latin1 select collation(group_concat(a,_koi8r'test')) from t1; collation(group_concat(a,_koi8r'test')) diff --git a/sql/item.cc b/sql/item.cc index eeb4b43b783..22c56fa5f2b 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -1191,7 +1191,7 @@ bool agg_item_charsets(DTCollation &coll, const char *fname, } THD *thd= current_thd; - Item_arena *arena, backup; + Query_arena *arena, backup; bool res= FALSE; /* In case we're in statement prepare, create conversion item @@ -1220,7 +1220,8 @@ bool agg_item_charsets(DTCollation &coll, const char *fname, res= TRUE; break; // we cannot return here, we need to restore "arena". } - conv->fix_fields(thd, 0, &conv); + if ((*arg)->type() == Item::FIELD_ITEM) + ((Item_field *)(*arg))->no_const_subst= 1; /* If in statement prepare, then we create a converter for two constant items, do it once and then reuse it. @@ -1235,6 +1236,11 @@ bool agg_item_charsets(DTCollation &coll, const char *fname, *arg= conv; else thd->change_item_tree(arg, conv); + /* + We do not check conv->fixed, because Item_func_conv_charset which can + be return by safe_charset_converter can't be fixed at creation + */ + conv->fix_fields(thd, arg); } if (arena) thd->restore_backup_item_arena(arena, &backup);