database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-10-31 15:50:51 +03:00
Code Activity

wl2077 - ndb close scan - fix introduced bugs wrt premature close of scan

Browse Source
This commit is contained in:
joreland@mysql.com
2004-11-21 22:15:44 +01:00
parent 56a59cf301
commit 4d43c10f3b
6 changed files with 19 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ndb/src/common/debugger/signaldata/ScanTab.cpp
View File

@@ -30,13 +30,14 @@ printSCANTABREQ(FILE * output, const Uint32 * theData, Uint32 len, Uint16 receiv
fprintf(output, " apiConnectPtr: H\'%.8x", fprintf(output, " apiConnectPtr: H\'%.8x",
sig->apiConnectPtr); sig->apiConnectPtr);
fprintf(output, " requestInfo: H\'%.8x:\n", requestInfo); fprintf(output, " requestInfo: H\'%.8x:\n", requestInfo);
fprintf(output, " Parallellism: %u, Batch: %u LockMode: %u, Keyinfo: %u Holdlock: %u, RangeScan: %u\n", fprintf(output, " Parallellism: %u, Batch: %u LockMode: %u, Keyinfo: %u Holdlock: %u, RangeScan: %u ReadCommitted: %u\n",
sig->getParallelism(requestInfo), sig->getParallelism(requestInfo),
sig->getScanBatch(requestInfo), sig->getScanBatch(requestInfo),
sig->getLockMode(requestInfo), sig->getLockMode(requestInfo),
sig->getKeyinfoFlag(requestInfo),
sig->getHoldLockFlag(requestInfo), sig->getHoldLockFlag(requestInfo),
sig->getRangeScanFlag(requestInfo), sig->getRangeScanFlag(requestInfo),
sig->getKeyinfoFlag(requestInfo)); sig->getReadCommittedFlag(requestInfo));
Uint32 keyLen = (sig->attrLenKeyLen >> 16); Uint32 keyLen = (sig->attrLenKeyLen >> 16);
Uint32 attrLen = (sig->attrLenKeyLen & 0xFFFF); Uint32 attrLen = (sig->attrLenKeyLen & 0xFFFF);

3
ndb/src/kernel/blocks/dbtc/DbtcMain.cpp
View File

@@ -9329,7 +9329,6 @@ void Dbtc::execSCAN_NEXTREQ(Signal* signal)
/********************************************************************* /*********************************************************************
* APPLICATION IS CLOSING THE SCAN. * APPLICATION IS CLOSING THE SCAN.
**********************************************************************/ **********************************************************************/
ndbrequire(len == 0);
close_scan_req(signal, scanptr, true); close_scan_req(signal, scanptr, true);
return; return;
}//if }//if
@@ -9457,7 +9456,7 @@ Dbtc::close_scan_req(Signal* signal, ScanRecordPtr scanPtr, bool req_received){
ndbrequire(curr.p->scanFragState == ScanFragRec::DELIVERED); ndbrequire(curr.p->scanFragState == ScanFragRec::DELIVERED);
delivered.remove(curr); delivered.remove(curr);
if(curr.p->m_ops > 0){ if(curr.p->m_ops > 0 && curr.p->m_scan_frag_conf_status == 0){
jam(); jam();
running.add(curr); running.add(curr);
curr.p->scanFragState = ScanFragRec::LQH_ACTIVE; curr.p->scanFragState = ScanFragRec::LQH_ACTIVE;

10
ndb/src/ndbapi/NdbConnectionScan.cpp
View File

@@ -57,12 +57,18 @@ NdbConnection::receiveSCAN_TABREF(NdbApiSignal* aSignal){
if(checkState_TransId(&ref->transId1)){ if(checkState_TransId(&ref->transId1)){
theScanningOp->theError.code = ref->errorCode; theScanningOp->theError.code = ref->errorCode;
theScanningOp->execCLOSE_SCAN_REP();
if(!ref->closeNeeded){ if(!ref->closeNeeded){
theScanningOp->execCLOSE_SCAN_REP();
return 0; return 0;
} }
assert(theScanningOp->m_sent_receivers_count);
/**
* Setup so that close_impl will actually perform a close
* and not "close scan"-optimze it away
*/
theScanningOp->m_conf_receivers_count++; theScanningOp->m_conf_receivers_count++;
theScanningOp->m_conf_receivers[0] = theScanningOp->m_receivers[0];
theScanningOp->m_conf_receivers[0]->m_tcPtrI = ~0;
return 0; return 0;
} else { } else {
#ifdef NDB_NO_DROPPED_SIGNAL #ifdef NDB_NO_DROPPED_SIGNAL

8
ndb/src/ndbapi/NdbScanOperation.cpp
View File

@@ -613,21 +613,22 @@ NdbScanOperation::send_next_scan(Uint32 cnt, bool stopScanFlag){
sent++; sent++;
} }
} }
memcpy(&m_api_receivers[0], &m_api_receivers[cnt], cnt * sizeof(char*)); memmove(m_api_receivers, m_api_receivers+cnt,
(theParallelism-cnt) * sizeof(char*));
int ret = 0; int ret = 0;
if(sent) if(sent)
{ {
Uint32 nodeId = theNdbCon->theDBnode; Uint32 nodeId = theNdbCon->theDBnode;
TransporterFacade * tp = TransporterFacade::instance(); TransporterFacade * tp = TransporterFacade::instance();
if(cnt > 21 && !stopScanFlag){ if(cnt > 21){
tSignal.setLength(4); tSignal.setLength(4);
LinearSectionPtr ptr[3]; LinearSectionPtr ptr[3];
ptr[0].p = prep_array; ptr[0].p = prep_array;
ptr[0].sz = sent; ptr[0].sz = sent;
ret = tp->sendSignal(&tSignal, nodeId, ptr, 1); ret = tp->sendSignal(&tSignal, nodeId, ptr, 1);
} else { } else {
tSignal.setLength(4+(stopScanFlag ? 0 : sent)); tSignal.setLength(4+sent);
ret = tp->sendSignal(&tSignal, nodeId); ret = tp->sendSignal(&tSignal, nodeId);
} }
} }
@@ -687,6 +688,7 @@ NdbScanOperation::execCLOSE_SCAN_REP(){
m_api_receivers_count = 0; m_api_receivers_count = 0;
m_conf_receivers_count = 0; m_conf_receivers_count = 0;
m_sent_receivers_count = 0; m_sent_receivers_count = 0;
m_current_api_receiver = theParallelism;
} }
void NdbScanOperation::release() void NdbScanOperation::release()

4
ndb/test/src/NDBT_Test.cpp
View File

@@ -839,9 +839,7 @@ void NDBT_TestSuite::execute(Ndb* ndb, const NdbDictionary::Table* pTab,
continue; continue;
} }
pTab2 = pDict->getTable(pTab->getName()); pTab2 = pDict->getTable(pTab->getName());
} else { }
pTab2 = pTab;
}
ctx = new NDBT_Context(); ctx = new NDBT_Context();
ctx->setTab(pTab2); ctx->setTab(pTab2);

2
ndb/tools/select_all.cpp
View File

@@ -50,7 +50,7 @@ static struct my_option my_long_options[] =
GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 }, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 },
{ "parallelism", 'p', "parallelism", { "parallelism", 'p', "parallelism",
(gptr*) &_parallelism, (gptr*) &_parallelism, 0, (gptr*) &_parallelism, (gptr*) &_parallelism, 0,
GET_INT, REQUIRED_ARG, 240, 0, 0, 0, 0, 0 }, GET_INT, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 },
{ "lock", 'l', "Read(0), Read-hold(1), Exclusive(2)", { "lock", 'l', "Read(0), Read-hold(1), Exclusive(2)",
(gptr*) &_lock, (gptr*) &_lock, 0, (gptr*) &_lock, (gptr*) &_lock, 0,
GET_INT, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 }, GET_INT, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 },