database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Uninitialized Column_definition::pack_flag for ROW-type SP variables and their fields

Browse Source 
Fixed that the Column_definition::pack_flag member corresponding to
ROW-type SP variables and their fields was not properly initialized.
This lead to sporadic test failures. Valgrind complained about jumps
depending on uninitialized value in VALGRIND builds.

This patch makes sure that sp_head::fill_spvar_definition() is always
called for ROW variables and their fields.

Additionally, fixed that a function with a scalar parameter
erroneously acceptes ROWs with one fields. Now an error is returned.
This commit is contained in:
Alexander Barkov
2017-03-31 21:20:32 +04:00
parent 281f8a42ee
commit 48a7ea6da3
9 changed files with 46 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/suite/compat/oracle/t/sp-row.test
View File

@ -351,7 +351,7 @@ BEGIN
END;
$$
DELIMITER ;$$
#--error ER_OPERAND_COLUMNS
--error ER_OPERAND_COLUMNS
CALL p1();
DROP PROCEDURE p1;
DROP FUNCTION f1;