From 1351bef4df851f7a867c0732d46a322165168b63 Mon Sep 17 00:00:00 2001
From: Michael Widenius <monty@askmonty.org>
Date: Wed, 5 Oct 2011 16:37:05 +0300
Subject: [PATCH] Fix for issue found in buildbot where mysqld.*.err files was
 missing Added suppression message for valgrind failure found on OpenSuSE 11.1

mysql-test/mysql-test-run.pl:
  Fix for issue found in buildbot where mysqld.*.err files was missing
  Patch by Kristian Nielsen
mysql-test/valgrind.supp:
  Added suppression message for valgrind failure found on OpenSuSE 11.1
sql/mysqld.cc:
  Added missing space to comment
---
 mysql-test/mysql-test-run.pl | 27 ---------------------------
 mysql-test/valgrind.supp     |  9 +++++++++
 sql/mysqld.cc                |  2 +-
 3 files changed, 10 insertions(+), 28 deletions(-)

diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl
index 6545812cc25..e480fcfd5fc 100755
--- a/mysql-test/mysql-test-run.pl
+++ b/mysql-test/mysql-test-run.pl
@@ -2862,7 +2862,6 @@ sub mysql_server_start($) {
     }
 
     if (-d $datadir ) {
-      preserve_error_log($mysqld);
       mtr_verbose(" - removing '$datadir'");
       rmtree($datadir);
     }
@@ -2891,7 +2890,6 @@ sub mysql_server_start($) {
       unless -d $datadir;
 
   }
-  restore_error_log($mysqld);
 
   # Create the servers tmpdir
   my $tmpdir= $mysqld->value('tmpdir');
@@ -4209,30 +4207,6 @@ sub run_testcase ($$) {
 }
 
 
-# We want to preserve the error log between server restarts, as it may contain
-# valuable debugging information even if there is no test failure recorded.
-sub _preserve_error_log_names {
-  my ($mysqld)= @_;
-  my $error_log_file= $mysqld->if_exist('#log-error');
-  return (undef, undef) unless $error_log_file;
-  my $error_log_dir= dirname($error_log_file);
-  my $save_name= $error_log_dir ."/../". $mysqld->name() .".error.log";
-  return ($error_log_file, $save_name);
-}
-
-sub preserve_error_log {
-  my ($mysqld)= @_;
-  my ($error_log_file, $save_name)= _preserve_error_log_names($mysqld);
-  rename($error_log_file, $save_name) if $save_name;
-  # Ignore any errors, as it's just a best-effort to keep the log if possible.
-}
-
-sub restore_error_log {
-  my ($mysqld)= @_;
-  my ($error_log_file, $save_name)= _preserve_error_log_names($mysqld);
-  rename($save_name, $error_log_file) if $save_name;
-}
-
 # Keep track of last position in mysqld error log where we scanned for
 # warnings, so we can attribute any warnings found to the correct test
 # suite or server restart.
@@ -4747,7 +4721,6 @@ sub clean_datadir {
 
   for (all_servers())
   {
-    preserve_error_log($_); # or at least, try to
     my $dir= "$opt_vardir/".$_->{name};
     mtr_verbose(" - removing '$dir'");
     rmtree($dir);
diff --git a/mysql-test/valgrind.supp b/mysql-test/valgrind.supp
index a5680746280..cbb5d54c1a0 100644
--- a/mysql-test/valgrind.supp
+++ b/mysql-test/valgrind.supp
@@ -395,6 +395,15 @@
    fun:_Z8udf_freev
 }
 
+{
+   dlsym memory loss from udf_free on SuSE 11.1 x64 variant 2
+   Memcheck:Leak
+   fun:calloc
+   obj:/lib*/ld-*.so
+   fun:dlclose
+   fun:udf_free
+}
+
 {
    dlclose memory loss from plugin variant 1
    Memcheck:Leak
diff --git a/sql/mysqld.cc b/sql/mysqld.cc
index 41ca0773782..d92eb15e6a4 100644
--- a/sql/mysqld.cc
+++ b/sql/mysqld.cc
@@ -7523,7 +7523,7 @@ thread is in the relay logs.",
    "Define threads usage for handling queries: "
    "one-thread-per-connection"
 #if HAVE_POOL_OF_THREADS == 1
-  ", pool-of-threads"
+  ", pool-of-threads "
 #endif
    "or no-threads.",
    &opt_thread_handling, &opt_thread_handling,