database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

MDEV-26647 (reuse info) Include password validation plugin information in the error message if the SQL statement is not satisfied password policy

Browse Source 
send information about password reusing
This commit is contained in:
Oleksandr Byelkin
2021-10-20 12:02:52 +02:00
parent 3f4eb6073f
commit 45a376dd2d
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/suite/plugins/r/password_reuse_check.result
View File

@@ -10,11 +10,13 @@ grant select on *.* to user_name@localhost identified by 'test_pwd';
ERROR HY000: Your password does not satisfy the current policy requirements ERROR HY000: Your password does not satisfy the current policy requirements
show warnings; show warnings;
Level Code Message Level Code Message
Warning 1819 password_reuse_check: The password was already used
Error 1819 Your password does not satisfy the current policy requirements Error 1819 Your password does not satisfy the current policy requirements
alter user user_name@localhost identified by 'test_pwd'; alter user user_name@localhost identified by 'test_pwd';
ERROR HY000: Operation ALTER USER failed for 'user_name'@'localhost' ERROR HY000: Operation ALTER USER failed for 'user_name'@'localhost'
show warnings; show warnings;
Level Code Message Level Code Message
Warning 1819 password_reuse_check: The password was already used
Error 1819 Your password does not satisfy the current policy requirements Error 1819 Your password does not satisfy the current policy requirements
Error 1396 Operation ALTER USER failed for 'user_name'@'localhost' Error 1396 Operation ALTER USER failed for 'user_name'@'localhost'
# check exparation # check exparation
@@ -23,6 +25,7 @@ alter user user_name@localhost identified by 'test_pwd';
ERROR HY000: Operation ALTER USER failed for 'user_name'@'localhost' ERROR HY000: Operation ALTER USER failed for 'user_name'@'localhost'
show warnings; show warnings;
Level Code Message Level Code Message
Warning 1819 password_reuse_check: The password was already used
Error 1819 Your password does not satisfy the current policy requirements Error 1819 Your password does not satisfy the current policy requirements
Error 1396 Operation ALTER USER failed for 'user_name'@'localhost' Error 1396 Operation ALTER USER failed for 'user_name'@'localhost'
select hex(hash) from mysql.password_reuse_check_history; select hex(hash) from mysql.password_reuse_check_history;

10
plugin/password_reuse_check/password_reuse_check.c
View File

@@ -108,9 +108,17 @@ static int run_query_with_table_creation(MYSQL *mysql, const char *query,
unsigned int rc= mysql_errno(mysql); unsigned int rc= mysql_errno(mysql);
if (rc != ER_NO_SUCH_TABLE) if (rc != ER_NO_SUCH_TABLE)
{ {
// suppress this error in case of try to add the same password twice
if (rc != ER_DUP_ENTRY) if (rc != ER_DUP_ENTRY)
{
report_sql_error(mysql); report_sql_error(mysql);
}
else
{
// warning used to do not change error code
my_printf_error(ER_NOT_VALID_PASSWORD,
"password_reuse_check: The password was already used",
ME_WARNING);
}
return 1; return 1;
} }
if (create_table(mysql)) if (create_table(mysql))