mirror of
https://github.com/MariaDB/server.git
synced 2025-07-30 16:24:05 +03:00
Lots of small cleanups
- Simplified use_trans_cache() to return at once if is_transactional is set - Indentation and spelling errors fixed - Don't call signal_update() if update_binlog_end_pos() is called as the function already calls signal_update() - Removed not used function wait_for_update_bin_log(), which would cause errors if ever used. - Simplified handler::clone() by always allocating 'ref' in ha_open(). To do this I added an optional MEM_ROOT argument to ha_open() to be used when allocating 'ref' - Changed arguments to get_system_var() from LEX_CSTRING to LEX_CSTRING* - Added THD as argument to create_select_for_variable(). Changed also char* argument to LEX_CSTRING to avoid strlen() call. - Change calls to append() to use LEX_CSTRING
This commit is contained in:
committed by
Sergei Golubchik
parent
a70f7aad55
commit
458d5ed8aa
@ -647,8 +647,7 @@ bool mysql_create_view(THD *thd, TABLE_LIST *views,
|
||||
{ C_STRING_WITH_LEN("ALTER ") },
|
||||
{ C_STRING_WITH_LEN("CREATE OR REPLACE ") }};
|
||||
|
||||
buff.append(command[thd->lex->create_view->mode].str,
|
||||
command[thd->lex->create_view->mode].length);
|
||||
buff.append(&command[thd->lex->create_view->mode]);
|
||||
view_store_options(thd, views, &buff);
|
||||
buff.append(STRING_WITH_LEN("VIEW "));
|
||||
|
||||
@ -680,7 +679,7 @@ bool mysql_create_view(THD *thd, TABLE_LIST *views,
|
||||
buff.append(')');
|
||||
}
|
||||
buff.append(STRING_WITH_LEN(" AS "));
|
||||
buff.append(views->source.str, views->source.length);
|
||||
buff.append(&views->source);
|
||||
|
||||
int errcode= query_error_code(thd, TRUE);
|
||||
/*
|
||||
|
Reference in New Issue
Block a user