database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

Merge fixes for --big tests and compiler warnings.

Browse Source
This commit is contained in:
unknown
2009-10-06 20:05:49 +02:00
parent 1d6e50c6d6 02c33646b3
commit 445ad6bd37
9 changed files with 52 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/include/mtr_check.sql
View File

@@ -12,7 +12,7 @@ BEGIN
-- Dump all global variables except those -- Dump all global variables except those
-- that are supposed to change -- that are supposed to change
SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
WHERE variable_name != 'timestamp' AND variable_name != "debug" WHERE variable_name != 'timestamp'
AND variable_name != 'INNODB_IBUF_MAX_SIZE' AND variable_name != 'INNODB_IBUF_MAX_SIZE'
ORDER BY variable_name; ORDER BY variable_name;

3
mysql-test/r/merge-big.result
View File

@@ -7,6 +7,7 @@ drop table if exists t1,t2,t3,t4,t5,t6;
CREATE TABLE t1 (c1 INT) ENGINE= MyISAM; CREATE TABLE t1 (c1 INT) ENGINE= MyISAM;
LOCK TABLE t1 WRITE; LOCK TABLE t1 WRITE;
# connection con1 # connection con1
SET @orig_debug=@@debug;
SET GLOBAL debug="+d,sleep_open_and_lock_after_open"; SET GLOBAL debug="+d,sleep_open_and_lock_after_open";
INSERT INTO t1 VALUES (1); INSERT INTO t1 VALUES (1);
# connection default # connection default
@@ -21,6 +22,6 @@ SELECT * FROM t1;
c1 c1
UNLOCK TABLES; UNLOCK TABLES;
# connection con1 # connection con1
SET GLOBAL debug="-d,sleep_open_and_lock_after_open"; SET GLOBAL debug=@orig_debug;
# connection default # connection default
DROP TABLE t1; DROP TABLE t1;

6
mysql-test/r/mysqlbinlog_row_big.result
View File

@@ -1,9 +1,4 @@
# #
# We need big packets.
#
SET @old_global_max_allowed_packet=@@global.max_allowed_packet;
SET @@global.max_allowed_packet= 1024*1024*1024;
#
# Preparatory cleanup. # Preparatory cleanup.
# #
DROP TABLE IF EXISTS t1; DROP TABLE IF EXISTS t1;
@@ -104,5 +99,4 @@ FLUSH LOGS;
# reset variable value to pass testcase checks # reset variable value to pass testcase checks
SET @@global.max_allowed_packet = 1048576; SET @@global.max_allowed_packet = 1048576;
DROP TABLE t1; DROP TABLE t1;
SET @@global.max_allowed_packet=@old_global_max_allowed_packet;
remove_file $MYSQLTEST_VARDIR/tmp/mysqlbinlog_big_1.out remove_file $MYSQLTEST_VARDIR/tmp/mysqlbinlog_big_1.out

40
mysql-test/r/variables-big.result
View File

@@ -1,20 +1,20 @@
set session transaction_prealloc_size=1024*1024*1024*1; SET SESSION transaction_prealloc_size=1024*1024*1024*1;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
TRUE Id User Host db Command Time State Info
1 <Id> root localhost test Query <Time> NULL SHOW PROCESSLIST
set session transaction_prealloc_size=1024*1024*1024*2; SET SESSION transaction_prealloc_size=1024*1024*1024*2;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
TRUE Id User Host db Command Time State Info
1 <Id> root localhost test Query <Time> NULL SHOW PROCESSLIST
set session transaction_prealloc_size=1024*1024*1024*3; SET SESSION transaction_prealloc_size=1024*1024*1024*3;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
TRUE Id User Host db Command Time State Info
1 <Id> root localhost test Query <Time> NULL SHOW PROCESSLIST
set session transaction_prealloc_size=1024*1024*1024*4; SET SESSION transaction_prealloc_size=1024*1024*1024*4;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
TRUE Id User Host db Command Time State Info
1 <Id> root localhost test Query <Time> NULL SHOW PROCESSLIST
set session transaction_prealloc_size=1024*1024*1024*5; SET SESSION transaction_prealloc_size=1024*1024*1024*5;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
TRUE Id User Host db Command Time State Info
1 <Id> root localhost test Query <Time> NULL SHOW PROCESSLIST

3
mysql-test/t/merge-big.test
View File

@@ -43,6 +43,7 @@ LOCK TABLE t1 WRITE;
--echo # connection con1 --echo # connection con1
connect (con1,localhost,root,,); connect (con1,localhost,root,,);
let $con1_id= `SELECT CONNECTION_ID()`; let $con1_id= `SELECT CONNECTION_ID()`;
SET @orig_debug=@@debug;
SET GLOBAL debug="+d,sleep_open_and_lock_after_open"; SET GLOBAL debug="+d,sleep_open_and_lock_after_open";
send INSERT INTO t1 VALUES (1); send INSERT INTO t1 VALUES (1);
--echo # connection default --echo # connection default
@@ -74,7 +75,7 @@ UNLOCK TABLES;
--echo # connection con1 --echo # connection con1
connection con1; connection con1;
reap; reap;
SET GLOBAL debug="-d,sleep_open_and_lock_after_open"; SET GLOBAL debug=@orig_debug;
disconnect con1; disconnect con1;
--echo # connection default --echo # connection default
connection default; connection default;

15
mysql-test/t/mysqlbinlog_row_big.test
View File

@@ -23,16 +23,6 @@
# This is a big test. # This is a big test.
--source include/big_test.inc --source include/big_test.inc
--echo #
--echo # We need big packets.
--echo #
connect (con1, localhost, root,,);
connection con1;
SET @old_global_max_allowed_packet=@@global.max_allowed_packet;
SET @@global.max_allowed_packet= 1024*1024*1024;
connect (con2, localhost, root,,);
connection con2;
--echo # --echo #
--echo # Preparatory cleanup. --echo # Preparatory cleanup.
--echo # --echo #
@@ -154,14 +144,9 @@ let $MYSQLD_DATADIR= `select @@datadir`;
eval SET @@global.max_allowed_packet = $orig_max_allowed_packet; eval SET @@global.max_allowed_packet = $orig_max_allowed_packet;
DROP TABLE t1; DROP TABLE t1;
connection con1;
SET @@global.max_allowed_packet=@old_global_max_allowed_packet;
--echo remove_file \$MYSQLTEST_VARDIR/$mysqlbinlog_output --echo remove_file \$MYSQLTEST_VARDIR/$mysqlbinlog_output
# #
# NOTE: If you want to see the *huge* mysqlbinlog output, disable next line: # NOTE: If you want to see the *huge* mysqlbinlog output, disable next line:
# #
--remove_file $MYSQLTEST_VARDIR/$mysqlbinlog_output --remove_file $MYSQLTEST_VARDIR/$mysqlbinlog_output
disconnect con1
disconnect con2

37
mysql-test/t/variables-big.test
View File

@@ -5,7 +5,7 @@
--source include/big_test.inc --source include/big_test.inc
# #
# Bug #27322 failure to allocate transaction_prealloc_size causes crash # Bug#27322 failure to allocate transaction_prealloc_size causes crash
# #
# #
# Manual (6.0): # Manual (6.0):
@@ -35,20 +35,21 @@
# timeout if the testing box is not powerful enough. # timeout if the testing box is not powerful enough.
# #
set @pid_temp = (select ID from information_schema.processlist); --disable_warnings
set session transaction_prealloc_size=1024*1024*1024*1; SET SESSION transaction_prealloc_size=1024*1024*1024*1;
--replace_column 1 # --replace_column 1 <Id> 6 <Time>
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
set session transaction_prealloc_size=1024*1024*1024*2; SET SESSION transaction_prealloc_size=1024*1024*1024*2;
--replace_column 1 # --replace_column 1 <Id> 6 <Time>
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SHOW PROCESSLIST;
--replace_column 1 # SET SESSION transaction_prealloc_size=1024*1024*1024*3;
set session transaction_prealloc_size=1024*1024*1024*3; --replace_column 1 <Id> 6 <Time>
--replace_column 1 # SHOW PROCESSLIST;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SET SESSION transaction_prealloc_size=1024*1024*1024*4;
set session transaction_prealloc_size=1024*1024*1024*4; --replace_column 1 <Id> 6 <Time>
--replace_column 1 # SHOW PROCESSLIST;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; SET SESSION transaction_prealloc_size=1024*1024*1024*5;
set session transaction_prealloc_size=1024*1024*1024*5; --replace_column 1 <Id> 6 <Time>
--replace_column 1 # SHOW PROCESSLIST;
select @pid_temp = (select ID from information_schema.processlist) as 'TRUE'; --enable_warnings

10
storage/maria/ma_blockrec.c
View File

@@ -5448,7 +5448,7 @@ static size_t fill_insert_undo_parts(MARIA_HA *info, const uchar *record,
Store total blob length to make buffer allocation easier during UNDO Store total blob length to make buffer allocation easier during UNDO
*/ */
log_parts->str= info->length_buff; log_parts->str= info->length_buff;
log_parts->length= (uint) (ma_store_length((uchar *) log_parts->str, log_parts->length= (uint) (ma_store_length(info->length_buff,
info->cur_row.blob_length) - info->cur_row.blob_length) -
(uchar*) log_parts->str); (uchar*) log_parts->str);
row_length+= log_parts->length; row_length+= log_parts->length;
@@ -5592,7 +5592,7 @@ static size_t fill_update_undo_parts(MARIA_HA *info, const uchar *oldrec,
MARIA_SHARE *share= info->s; MARIA_SHARE *share= info->s;
MARIA_COLUMNDEF *column, *end_column; MARIA_COLUMNDEF *column, *end_column;
MARIA_ROW *old_row= &info->cur_row, *new_row= &info->new_row; MARIA_ROW *old_row= &info->cur_row, *new_row= &info->new_row;
uchar *field_data, *start_field_data; uchar *field_data, *start_field_data, *length_str;
uchar *old_field_lengths= old_row->field_lengths; uchar *old_field_lengths= old_row->field_lengths;
uchar *new_field_lengths= new_row->field_lengths; uchar *new_field_lengths= new_row->field_lengths;
size_t row_length= 0; size_t row_length= 0;
@@ -5749,9 +5749,9 @@ static size_t fill_update_undo_parts(MARIA_HA *info, const uchar *oldrec,
/* Store length of field length data before the field/field_lengths */ /* Store length of field length data before the field/field_lengths */
field_lengths= (uint) (field_data - start_field_data); field_lengths= (uint) (field_data - start_field_data);
start_log_parts->str= ((start_field_data - length_str= start_field_data - ma_calc_length_for_store_length(field_lengths);
ma_calc_length_for_store_length(field_lengths))); start_log_parts->str= length_str;
ma_store_length((uchar*)start_log_parts->str, field_lengths); ma_store_length(length_str, field_lengths);
start_log_parts->length= (size_t) (field_data - start_log_parts->str); start_log_parts->length= (size_t) (field_data - start_log_parts->str);
row_length+= start_log_parts->length; row_length+= start_log_parts->length;
DBUG_RETURN(row_length); DBUG_RETURN(row_length);

3
support-files/compiler_warnings.supp
View File

@@ -109,3 +109,6 @@ ma_packrec.c : .*result of 32-bit shift implicitly converted to 64 bits.* : 550-
# #
.* : .*no matching operator delete found; memory will not be freed if initialization throws an exception.* .* : .*no matching operator delete found; memory will not be freed if initialization throws an exception.*
ctype-simple.c : .*unary minus operator applied to unsigned type, result still unsigned.* ctype-simple.c : .*unary minus operator applied to unsigned type, result still unsigned.*
# Wrong warning due to GCC bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29478
regexec\.c : .*passing argument 3 of.*matcher.* discards qualifiers from pointer target type.*