database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

BUG#20809 mysqldump does not backup TS and LG information correctly.

Browse Source 
We were not parsing the EXTRA field to get UNDO_BUFFER_SIZE for the
CREATE LOGFILE GROUP statement in the dump.
This commit is contained in:
stewart@willster.(none)
2006-09-19 17:07:21 +10:00
parent a2928a35d8
commit 40dffeba03
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
client/mysqldump.c
View File

@ -2737,6 +2737,12 @@ static int dump_all_tablespaces()
MYSQL_RES *tableres; MYSQL_RES *tableres;
char buf[FN_REFLEN]; char buf[FN_REFLEN];
int first; int first;
/*
The following are used for parsing the EXTRA field
*/
char extra_format[]= "UNDO_BUFFER_SIZE=";
char *ubs;
char *endsemi;
if (mysql_query_with_error_report(mysql, &tableres, if (mysql_query_with_error_report(mysql, &tableres,
"SELECT DISTINCT" "SELECT DISTINCT"
@ -2744,9 +2750,11 @@ static int dump_all_tablespaces()
" FILE_NAME," " FILE_NAME,"
" TOTAL_EXTENTS," " TOTAL_EXTENTS,"
" INITIAL_SIZE," " INITIAL_SIZE,"
" ENGINE" " ENGINE,"
" EXTRA"
" FROM INFORMATION_SCHEMA.FILES" " FROM INFORMATION_SCHEMA.FILES"
" WHERE FILE_TYPE = \"UNDO LOG\"" " WHERE FILE_TYPE = \"UNDO LOG\""
" AND FILE_NAME IS NOT NULL"
" ORDER BY LOGFILE_GROUP_NAME")) " ORDER BY LOGFILE_GROUP_NAME"))
return 1; return 1;
@ -2775,9 +2783,16 @@ static int dump_all_tablespaces()
row[1]); row[1]);
if (first) if (first)
{ {
ubs= strstr(row[5],extra_format);
if(!ubs)
break;
ubs+= strlen(extra_format);
endsemi= strstr(ubs,";");
if(endsemi)
endsemi[0]= '\0';
fprintf(md_result_file, fprintf(md_result_file,
" UNDO_BUFFER_SIZE %s\n", " UNDO_BUFFER_SIZE %s\n",
row[2]); ubs);
} }
fprintf(md_result_file, fprintf(md_result_file,
" INITIAL_SIZE %s\n" " INITIAL_SIZE %s\n"