database/mariadb
database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-04-17 10:37:22 +03:00
Code

Review fixes

Browse Source 
- explain why "long" is deprecated, point out to Wikipedia 64bit data models article.
- fix typo
This commit is contained in:
Vladislav Vaintroub 2025-03-03 12:00:36 +01:00
parent 1fecf581ac
commit 3a81664cb8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CODING_STANDARDS.md
View File

@ -364,7 +364,8 @@ my_function(thd, db_name);
The usage of types `long` and `unsigned long` (and its `ulong` alias)
in new code is *strongly* discouraged. Its use brings no advantages,
only portability problems between Windows and Unixes.
only portability problems between Windows and Unixes. The reason for it is that `long`
appears to be the only standard C/C++ datatype, with [size that differs between mainstream 64bit OSes](https://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models)
Instead of using `long`, use `size_t` and `ptrdiff_t` where appropriate,
buffer sizes for example. For integer socket descriptor use `my_socket`.
@ -376,4 +377,4 @@ You may use types with fixed length, int32_t and similar, too. Yet, on all platf
* `long long` is 64bit
and the above is not likely to change for the decades to come. Those types are safe to use. When using `char`
though, be aware that its signdness can depend on compiler flags, so do not assume it can take negative values.
though, be aware that its signed-ness can depend on compiler flags, so do not assume it can take negative values.