database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Make sure that variables which are (or may be) used

Browse Source 
in an ".opt" file are defined to some value (even
if it is empty). Without this, a test suite run
aborted on Windows for "embedded".

This fix was applied dusing the build of 5.4.2-beta.


mysql-test/mysql-test-run.pl:
  From the code (function "envsubst()"), it is obvious
  that any variable which is used in an ".opt" file needs
  to be defined.
  If the value is wrong, starting the server may fail -
  but if the variable is undefined, the whole test suite
  will abort.
  
  So variables which are used in an ".opt" file should
  always be defined to some value, even if it is blank.
  
  This fix may be overkill, I did not check in detail
  whether all these variables are really used in an ".opt"
  file - but some are.
This commit is contained in:
Joerg Bruehe
2009-09-08 16:10:06 +02:00
parent eb26de2356
commit 36703050e8
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mysql-test/mysql-test-run.pl
View File

@ -1781,6 +1781,14 @@ sub environment_setup {
$ENV{'HA_EXAMPLE_SO'}="'".$plugin_filename."'";
$ENV{'EXAMPLE_PLUGIN_LOAD'}="--plugin_load=;EXAMPLE=".$plugin_filename.";";
}
else
{
# Some ".opt" files use some of these variables, so they must be defined
$ENV{'EXAMPLE_PLUGIN'}= "";
$ENV{'EXAMPLE_PLUGIN_OPT'}= "";
$ENV{'HA_EXAMPLE_SO'}= "";
$ENV{'EXAMPLE_PLUGIN_LOAD'}= "";
}
# ----------------------------------------------------
# Add the path where mysqld will find mypluglib.so