database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Remove no longer needed TODO.

Browse Source
This commit is contained in:
Vicențiu Ciorbaru
2016-03-16 01:14:43 +02:00
parent 333ac13be5
commit 350903e952
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sql/sql_window.cc
View File

@ -1261,13 +1261,6 @@ bool compute_window_func_with_frames(Item_window_func *item_win,
*/ */
tbl->file->ha_rnd_pos(tbl->record[0], rowid_buf); tbl->file->ha_rnd_pos(tbl->record[0], rowid_buf);
store_record(tbl,record[1]); store_record(tbl,record[1]);
// TODO-cvicentiu
// Save in field does not make use of the null value for the sum function.
// If we do however set the null value to be the same as the one that
// the current sum function has, via say
// item_win->null_value = sum_func->null_value; we get an assertion failure
// during the sending of data within Item::send, in the case of DECIMAL_RESULT.
// How do we force saving of NULL values in the table?
item_win->save_in_field(item_win->result_field, true); item_win->save_in_field(item_win->result_field, true);
err= tbl->file->ha_update_row(tbl->record[1], tbl->record[0]); err= tbl->file->ha_update_row(tbl->record[1], tbl->record[0]);
if (err && err != HA_ERR_RECORD_IS_THE_SAME) if (err && err != HA_ERR_RECORD_IS_THE_SAME)