database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

cleanup: remove redundant vers_field->set_notnull();

Browse Source 
as these fields are always declared NOT NULL anyway
This commit is contained in:
Sergei Golubchik
2018-02-24 21:53:33 +01:00
parent 8936b17510
commit 30981dcf56
3 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sql/log_event.cc
View File

@ -13571,9 +13571,6 @@ int Rows_log_event::find_row(rpl_group_info *rgi)
// check whether master table is unversioned // check whether master table is unversioned
if (row_end->val_int() == 0) if (row_end->val_int() == 0)
{ {
// row_start initialized with NULL when came from plain table.
// Set it notnull() because record_compare() count NULLs.
table->vers_start_field()->set_notnull();
bitmap_set_bit(table->write_set, row_end->field_index); bitmap_set_bit(table->write_set, row_end->field_index);
// Plain source table may have a PRIMARY KEY. And row_end is always // Plain source table may have a PRIMARY KEY. And row_end is always
// a part of PRIMARY KEY. Set it to max value for engine to find it in // a part of PRIMARY KEY. Set it to max value for engine to find it in

1
sql/sql_insert.cc
View File

@ -1933,7 +1933,6 @@ int write_record(THD *thd, TABLE *table,COPY_INFO *info)
if (table->versioned(VERS_TRX_ID)) if (table->versioned(VERS_TRX_ID))
{ {
bitmap_set_bit(table->write_set, table->vers_start_field()->field_index); bitmap_set_bit(table->write_set, table->vers_start_field()->field_index);
table->vers_start_field()->set_notnull();
table->vers_start_field()->store(0, false); table->vers_start_field()->store(0, false);
} }
if ((error=table->file->ha_update_row(table->record[1], if ((error=table->file->ha_update_row(table->record[1],

3
sql/table.cc
View File

@ -7764,14 +7764,12 @@ void TABLE::vers_update_fields()
{ {
if (!vers_write) if (!vers_write)
return; return;
vers_start_field()->set_notnull();
if (vers_start_field()->store_timestamp(in_use->system_time, if (vers_start_field()->store_timestamp(in_use->system_time,
in_use->system_time_sec_part)) in_use->system_time_sec_part))
DBUG_ASSERT(0); DBUG_ASSERT(0);
} }
else else
{ {
vers_start_field()->set_notnull();
if (!vers_write) if (!vers_write)
return; return;
} }
@ -7782,7 +7780,6 @@ void TABLE::vers_update_fields()
void TABLE::vers_update_end() void TABLE::vers_update_end()
{ {
vers_end_field()->set_notnull();
if (vers_end_field()->store_timestamp(in_use->system_time, if (vers_end_field()->store_timestamp(in_use->system_time,
in_use->system_time_sec_part)) in_use->system_time_sec_part))
DBUG_ASSERT(0); DBUG_ASSERT(0);