mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
MDEV-23730 s3.replication_partition 'innodb,mix' segv
This failure was caused because of several bugs: - Someone had removed s3-slave-ignore-updates=1 from slave.cnf, which caused the slave to remove files that the master was working on. - Bug in ha_partition::change_partitions() that didn't reset m_new_file in case of errors. This caused crashes in ha_maria::extra() as the maria handler was called on files that was already closed. - In ma_pagecache there was a bug that when one got a read error one a big block (s3 block), it left the flag PCBLOCK_BIG_READ on for the page which cased an assert when the page where flushed. - Flush all cached tables in case of ignored ALTER TABLE Note that when merging code from 10.3, that fixes the partition bug, use the code from this patch instead. Changes to ma_pagecache.cc written or reviewed by Sanja
This commit is contained in:
@@ -7,6 +7,12 @@
|
||||
--source create_database.inc
|
||||
|
||||
sync_slave_with_master;
|
||||
|
||||
if (`select @@s3_slave_ignore_updates <> 1`)
|
||||
{
|
||||
die "Slave is not configured with s3-slave-ignore-updates=1";
|
||||
}
|
||||
|
||||
let $MYSQLD_DATADIR= `select @@datadir`;
|
||||
--replace_result $database database
|
||||
--eval use $database
|
||||
@@ -65,20 +71,8 @@ sync_slave_with_master;
|
||||
select sum(c1)+0 from t1;
|
||||
stop slave;
|
||||
|
||||
# .frm amd .par files should not exists on the salve as it has just seen the
|
||||
# ALTER TABLE which cased the removal of the .frm and .par files. The table
|
||||
# from the above "select sum()" came from table cache and was used as it's
|
||||
# id matches the one in S3
|
||||
--error 1
|
||||
--file_exists $MYSQLD_DATADIR/$database/t1.frm
|
||||
--error 1
|
||||
--file_exists $MYSQLD_DATADIR/$database/t1.par
|
||||
# Flushing the table cache will force the .frm and .par files to be
|
||||
# re-generated
|
||||
flush tables;
|
||||
select sum(c1)+0 from t1;
|
||||
--file_exists $MYSQLD_DATADIR/$database/t1.frm
|
||||
--file_exists $MYSQLD_DATADIR/$database/t1.par
|
||||
# Ensure the slave is using the new table
|
||||
show create table t1;
|
||||
|
||||
connection master;
|
||||
drop table t1;
|
||||
|
Reference in New Issue
Block a user