mirror of
https://github.com/MariaDB/server.git
synced 2025-07-29 05:21:33 +03:00
MDEV-13478 Full SST sync fails because of the error in the cleaning part
Problem: The command was: find $paths -mindepth 1 -regex $cpat -prune -o -exec rm -rf {} \+ Which was supposed to work as * skipping $paths directories themselves (-mindepth 1) * see if the dir/file name matches $cpat (-regex) * if yes - don't dive into the directory, skip it (-prune) * otherwise (-o) * remove it and everything inside (-exec) Now -exec ... \+ works like this: every new found path is appended to the end of the command line. when accumulated command line length reaches `getconf ARG_MAX` (~2Gb) it's executed, and find continues, appending to a new command line. What happens here, find appends some directory to the command line, then dives into it, and starts appending files from that directory. At some point command line overflows, rm -rf gets executed and removes the whole directory. Now find tries to continue scanning the directory that was already removed. Fix: don't dive into directories that will be recursively removed anyway, use -prune for them. Basically, we should be pruning both paths that have matched $cpat and paths that have not matched it. This is achived by pruning unconditionally, before the regex is tested: find $paths -mindepth 1 -prune -regex $cpat -o -exec rm -rf {} \+ Patch Credit:- Serg
This commit is contained in:
committed by
Sergei Golubchik
parent
353fe8a321
commit
2a4faa8ab6
@ -1072,7 +1072,7 @@ then
|
|||||||
|
|
||||||
|
|
||||||
wsrep_log_info "Cleaning the existing datadir and innodb-data/log directories"
|
wsrep_log_info "Cleaning the existing datadir and innodb-data/log directories"
|
||||||
find $ib_home_dir $ib_log_dir $ib_undo_dir $DATA -mindepth 1 -regex $cpat -prune -o -exec rm -rfv {} 1>&2 \+
|
find $ib_home_dir $ib_log_dir $ib_undo_dir $DATA -mindepth 1 -prune -regex $cpat -o -exec rm -rfv {} 1>&2 \+
|
||||||
|
|
||||||
tempdir=$(parse_cnf mysqld log-bin "")
|
tempdir=$(parse_cnf mysqld log-bin "")
|
||||||
if [[ -n ${tempdir:-} ]];then
|
if [[ -n ${tempdir:-} ]];then
|
||||||
|
Reference in New Issue
Block a user