database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-18 23:03:28 +03:00
Code Activity

fixed Bug #2985

Browse Source 
"Table truncated when creating another table name with Spaces"
added to check_db_name, check_table_name and check_column_name
test for end space
This commit is contained in:
vva@eagle.mysql.r18.ru
2004-03-05 22:13:33 +04:00
parent f074349917
commit 29bc7b03a0
5 changed files with 49 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mysql-test/r/create.result
View File

@ -216,3 +216,9 @@ a b
0 2
3 4
drop table t1;
create table `t1 `(a int);
Incorrect table name 't1 '
create database `db1 `;
Incorrect database name 'db1 '
create table t1(`a ` int);
Incorrect column name 'a '

12
mysql-test/t/create.test
View File

@ -179,3 +179,15 @@ create table if not exists t1 select 3 as 'a',4 as 'b';
create table if not exists t1 select 3 as 'a',3 as 'b';
select * from t1;
drop table t1;
#
# Test for Bug #2985
# "Table truncated when creating another table name with Spaces"
#
--error 1103
create table `t1 `(a int);
--error 1102
create database `db1 `;
--error 1166;
create table t1(`a ` int);

2
sql/sql_db.cc
View File

@ -376,7 +376,7 @@ bool mysql_change_db(THD *thd,const char *name)
ulong db_access;
DBUG_ENTER("mysql_change_db");
if (!dbname || !(db_length=strip_sp(dbname)))
if (!dbname || !(db_length= strlength(dbname)))
{
x_free(dbname); /* purecov: inspected */
send_error(&thd->net,ER_NO_DB_ERROR); /* purecov: inspected */

12
sql/sql_parse.cc
View File

@ -1123,8 +1123,7 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
statistic_increment(com_stat[SQLCOM_CREATE_DB],&LOCK_status);
// null test to handle EOM
if (!db || !strip_sp(db) || !(alias= thd->strdup(db)) ||
check_db_name(db))
if (!db || !(alias= thd->strdup(db)) || check_db_name(db))
{
net_printf(&thd->net,ER_WRONG_DB_NAME, db ? db : "NULL");
break;
@ -1140,8 +1139,7 @@ bool dispatch_command(enum enum_server_command command, THD *thd,
statistic_increment(com_stat[SQLCOM_DROP_DB],&LOCK_status);
char *db=thd->strdup(packet), *alias;
// null test to handle EOM
if (!db || !strip_sp(db) || !(alias= thd->strdup(db)) ||
check_db_name(db))
if (!db || !(alias= thd->strdup(db)) || check_db_name(db))
{
net_printf(&thd->net,ER_WRONG_DB_NAME, db ? db : "NULL");
break;
@ -2320,8 +2318,7 @@ mysql_execute_command(void)
case SQLCOM_CREATE_DB:
{
char *alias;
if (!strip_sp(lex->name) || !(alias=thd->strdup(lex->name)) ||
check_db_name(lex->name))
if (!(alias=thd->strdup(lex->name)) || check_db_name(lex->name))
{
net_printf(&thd->net,ER_WRONG_DB_NAME, lex->name);
break;
@ -2350,8 +2347,7 @@ mysql_execute_command(void)
case SQLCOM_DROP_DB:
{
char *alias;
if (!strip_sp(lex->name) || !(alias=thd->strdup(lex->name)) ||
check_db_name(lex->name))
if (!(alias=thd->strdup(lex->name)) || check_db_name(lex->name))
{
net_printf(&thd->net,ER_WRONG_DB_NAME, lex->name);
break;

28
sql/table.cc
View File

@ -1139,7 +1139,8 @@ char *get_field(MEM_ROOT *mem, TABLE *table, uint fieldnr)
bool check_db_name(char *name)
{
char *start=name;
char *start=name;
bool space= false;
if (lower_case_table_names)
casedn_str(name);
@ -1147,6 +1148,7 @@ bool check_db_name(char *name)
while (*name)
{
#if defined(USE_MB) && defined(USE_MB_IDENT)
space= my_isspace(default_charset_info, *name);
if (use_mb(default_charset_info))
{
int len=my_ismbchar(default_charset_info, name, name+MBMAXLEN);
@ -1156,19 +1158,24 @@ bool check_db_name(char *name)
continue;
}
}
#else
space= *name==' ';
#endif
if (*name == '/' || *name == '\\' || *name == FN_LIBCHAR ||
*name == FN_EXTCHAR)
return 1;
name++;
}
return (uint) (name - start) > NAME_LEN;
if (space)
return 1;
return name[-1]==' ' || (uint) (name - start) > NAME_LEN;
}
/*
Allow anything as a table name, as long as it doesn't contain an
a '/', or a '.' character
or ' ' at the end
returns 1 on error
*/
@ -1178,10 +1185,17 @@ bool check_table_name(const char *name, uint length)
const char *end= name+length;
if (!length || length > NAME_LEN)
return 1;
#if defined(USE_MB) && defined(USE_MB_IDENT)
bool space= false;
#else
if (name[length-1]==' ')
return 1;
#endif
while (name != end)
{
#if defined(USE_MB) && defined(USE_MB_IDENT)
space= my_isspace(default_charset_info, *name);
if (use_mb(default_charset_info))
{
int len=my_ismbchar(default_charset_info, name, end);
@ -1196,16 +1210,22 @@ bool check_table_name(const char *name, uint length)
return 1;
name++;
}
#if defined(USE_MB) && defined(USE_MB_IDENT)
if (space)
return 1;
#endif
return 0;
}
bool check_column_name(const char *name)
{
const char *start= name;
bool space= false;
while (*name)
{
#if defined(USE_MB) && defined(USE_MB_IDENT)
space= my_isspace(default_charset_info, *name);
if (use_mb(default_charset_info))
{
int len=my_ismbchar(default_charset_info, name, name+MBMAXLEN);
@ -1215,11 +1235,15 @@ bool check_column_name(const char *name)
continue;
}
}
#else
space= *name==' ';
#endif
if (*name == NAMES_SEP_CHAR)
return 1;
name++;
}
if (space)
return 1;
/* Error if empty or too long column name */
return (name == start || (uint) (name - start) > NAME_LEN);
}