database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

MDEV-4243 Warnings/errors while compiling with clang

Browse Source
This commit is contained in:
Sergei Golubchik
2013-03-28 20:04:14 +01:00
parent 7868367270
commit 2901497b18
13 changed files with 19 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libmysqld/lib_sql.cc
View File

@ -440,7 +440,7 @@ static MYSQL_RES * emb_store_result(MYSQL *mysql)
int emb_read_change_user_result(MYSQL *mysql) int emb_read_change_user_result(MYSQL *mysql)
{ {
mysql->net.read_pos= (uchar*)""; // fake an OK packet mysql->net.read_pos= (uchar*)""; // fake an OK packet
return mysql_errno(mysql) ? packet_error : 1 /* length of the OK packet */; return mysql_errno(mysql) ? (int)packet_error : 1 /* length of the OK packet */;
} }
MYSQL_METHODS embedded_methods= MYSQL_METHODS embedded_methods=

2
mysys/default.c
View File

@ -814,7 +814,7 @@ static int search_default_file_with_ext(Process_option_func opt_handler,
continue; continue;
/* Configuration File Directives */ /* Configuration File Directives */
if ((*ptr == '!')) if (*ptr == '!')
{ {
if (recursion_level >= max_recursion_level) if (recursion_level >= max_recursion_level)
{ {

2
sql/log.cc
View File

@ -2253,7 +2253,7 @@ static int find_uniq_filename(char *name)
my_dirend(dir_info); my_dirend(dir_info);
/* check if reached the maximum possible extension number */ /* check if reached the maximum possible extension number */
if ((max_found == MAX_LOG_UNIQUE_FN_EXT)) if (max_found == MAX_LOG_UNIQUE_FN_EXT)
{ {
sql_print_error("Log filename extension number exhausted: %06lu. \ sql_print_error("Log filename extension number exhausted: %06lu. \
Please fix this by archiving old logs and \ Please fix this by archiving old logs and \

2
sql/log_event.cc
View File

@ -1369,7 +1369,7 @@ failed my_b_read"));
Log_event *res= 0; Log_event *res= 0;
#ifndef max_allowed_packet #ifndef max_allowed_packet
THD *thd=current_thd; THD *thd=current_thd;
uint max_allowed_packet= thd ? slave_max_allowed_packet:~(ulong)0; uint max_allowed_packet= thd ? slave_max_allowed_packet:~(uint)0;
#endif #endif
if (data_len > max_allowed_packet) if (data_len > max_allowed_packet)

2
sql/opt_sum.cc
View File

@ -84,7 +84,7 @@ static ulonglong get_exact_record_count(List<TABLE_LIST> &tables)
while ((tl= ti++)) while ((tl= ti++))
{ {
ha_rows tmp= tl->table->file->records(); ha_rows tmp= tl->table->file->records();
if ((tmp == HA_POS_ERROR)) if (tmp == HA_POS_ERROR)
return ULONGLONG_MAX; return ULONGLONG_MAX;
count*= tmp; count*= tmp;
} }

6
storage/csv/ha_tina.cc
View File

@ -1436,9 +1436,9 @@ int ha_tina::rnd_end()
DBUG_RETURN(-1); DBUG_RETURN(-1);
/* Open the file again */ /* Open the file again */
if (((data_file= mysql_file_open(csv_key_file_data, if ((data_file= mysql_file_open(csv_key_file_data,
share->data_file_name, share->data_file_name,
O_RDONLY, MYF(MY_WME))) == -1)) O_RDONLY, MYF(MY_WME))) == -1)
DBUG_RETURN(my_errno ? my_errno : -1); DBUG_RETURN(my_errno ? my_errno : -1);
/* /*
As we reopened the data file, increase share->data_file_version As we reopened the data file, increase share->data_file_version

2
storage/federatedx/ha_federatedx.cc
View File

@ -764,7 +764,7 @@ static int parse_url(MEM_ROOT *mem_root, FEDERATEDX_SHARE *share, TABLE *table,
user:@hostname:port/db/table user:@hostname:port/db/table
Then password is a null string, so set to NULL Then password is a null string, so set to NULL
*/ */
if ((share->password[0] == '\0')) if (share->password[0] == '\0')
share->password= NULL; share->password= NULL;
} }

4
storage/innobase/sync/sync0sync.c
View File

@ -316,9 +316,9 @@ mutex_create_func(
/* NOTE! The very first mutexes are not put to the mutex list */ /* NOTE! The very first mutexes are not put to the mutex list */
if ((mutex == &mutex_list_mutex) if (mutex == &mutex_list_mutex
#ifdef UNIV_SYNC_DEBUG #ifdef UNIV_SYNC_DEBUG
|| (mutex == &sync_thread_mutex) || mutex == &sync_thread_mutex
#endif /* UNIV_SYNC_DEBUG */ #endif /* UNIV_SYNC_DEBUG */
) { ) {

11
storage/maria/ma_bitmap.c
View File

@ -135,8 +135,7 @@ const char *bits_to_txt[]=
"tail 00-40 % full", "tail 40-80 % full", "tail/blob full" "tail 00-40 % full", "tail 40-80 % full", "tail/blob full"
}; };
/*#define WRONG_BITMAP_FLUSH 1*/ /*define only for provoking bugs*/ #define WRONG_BITMAP_FLUSH 0 /*define to 1 only for provoking bugs*/
#undef WRONG_BITMAP_FLUSH
static my_bool _ma_read_bitmap_page(MARIA_HA *info, static my_bool _ma_read_bitmap_page(MARIA_HA *info,
MARIA_FILE_BITMAP *bitmap, MARIA_FILE_BITMAP *bitmap,
@ -164,11 +163,7 @@ static inline my_bool write_changed_bitmap(MARIA_SHARE *share,
*/ */
bitmap->changed_not_flushed= 1; bitmap->changed_not_flushed= 1;
if ((bitmap->non_flushable == 0) if ((bitmap->non_flushable == 0) || WRONG_BITMAP_FLUSH)
#ifdef WRONG_BITMAP_FLUSH
|| 1
#endif
)
{ {
res= pagecache_write(share->pagecache, res= pagecache_write(share->pagecache,
&bitmap->file, bitmap->page, 0, &bitmap->file, bitmap->page, 0,
@ -495,7 +490,7 @@ my_bool _ma_bitmap_flush_all(MARIA_SHARE *share)
{ {
bitmap->flush_all_requested++; bitmap->flush_all_requested++;
bitmap->waiting_for_non_flushable++; bitmap->waiting_for_non_flushable++;
#ifndef WRONG_BITMAP_FLUSH #if !WRONG_BITMAP_FLUSH
while (bitmap->non_flushable > 0) while (bitmap->non_flushable > 0)
{ {
DBUG_PRINT("info", ("waiting for bitmap to be flushable")); DBUG_PRINT("info", ("waiting for bitmap to be flushable"));

2
storage/maria/ma_blockrec.c
View File

@ -7123,7 +7123,7 @@ my_bool _ma_apply_undo_row_delete(MARIA_HA *info, LSN undo_lsn,
memcpy(field_pos, field_length_data, size_length); memcpy(field_pos, field_length_data, size_length);
field_length_data+= size_length; field_length_data+= size_length;
memcpy(field_pos + size_length, &header, sizeof(&header)); memcpy(field_pos + size_length, &header, sizeof(header));
header+= blob_length; header+= blob_length;
*blob_lengths++= blob_length; *blob_lengths++= blob_length;
break; break;

2
storage/maria/ma_test3.c
View File

@ -114,7 +114,7 @@ int main(int argc,char **argv)
sleep(1); sleep(1);
return 0; return 0;
} }
rnd(1); (void)rnd(1);
} }
for (i=0 ; i < forks ; i++) for (i=0 ; i < forks ; i++)

4
storage/xtradb/sync/sync0sync.c
View File

@ -315,9 +315,9 @@ mutex_create_func(
/* NOTE! The very first mutexes are not put to the mutex list */ /* NOTE! The very first mutexes are not put to the mutex list */
if ((mutex == &mutex_list_mutex) if (mutex == &mutex_list_mutex
#ifdef UNIV_SYNC_DEBUG #ifdef UNIV_SYNC_DEBUG
|| (mutex == &sync_thread_mutex) || mutex == &sync_thread_mutex
#endif /* UNIV_SYNC_DEBUG */ #endif /* UNIV_SYNC_DEBUG */
) { ) {

2
strings/decimal.c
View File

@ -669,7 +669,7 @@ int decimal_shift(decimal_t *dec, int shift)
if (do_left) if (do_left)
{ {
do_mini_left_shift(dec, l_mini_shift, beg, end); do_mini_left_shift(dec, l_mini_shift, beg, end);
mini_shift=- l_mini_shift; mini_shift= -l_mini_shift;
} }
else else
{ {