database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

wt: don't support a key as a union { ulonglong, void* }. Although convenient,

Browse Source 
it forces the user to bzero a key before setting it as a pointer, otherwise
it'll have random content on architectures where
sizeof(void*) < sizeof(ulonglong).

Declaring a key as ulonglong only (not a union) makes this user mistake
impossible.

include/waiting_threads.h:
  WT_RESOURCE_ID::value is an ulonglong, not a union
mysys/waiting_threads.c:
  WT_RESOURCE_ID::value is an ulonglong, not a union
storage/maria/ma_write.c:
  WT_RESOURCE_ID::value is an ulonglong, not a union
storage/maria/trnman.c:
  WT_RESOURCE_ID::value is an ulonglong, not a union
unittest/mysys/waiting_threads-t.c:
  WT_RESOURCE_ID::value is an ulonglong, not a union
This commit is contained in:
Sergei Golubchik
2008-09-01 21:43:11 +02:00
parent 533deb0ac4
commit 27dadbd895
5 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/waiting_threads.h
View File

@@ -32,10 +32,7 @@ typedef struct st_wt_resource_type {
struct st_wt_resource_id {
WT_RESOURCE_TYPE *type;
union {
void *ptr;
ulonglong num;
} value;
ulonglong value;
};
#define WT_WAIT_STATS 24