database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-29189 Crash of the second execution of SF using DELETE/UPDATE

Browse Source 
This bug caused a crash of the server at the second execution of a stored
function that used DELETE or UPDATE statement if the first execution
of this function reported an error encountered after the prepare phase.
This happened because in such cases the executed DELETE/UPDATE statement
remained marked as prepared. As a result the second execution of SF missed
the prepare phase for the statement altogether and the statement could not
be executed properly.

Approved by Oleksandr Byelkin <sanja@mariadb.com>
This commit is contained in:
Igor Babaev
2022-07-28 17:52:47 -07:00
parent 9f79652625
commit 24f75b7f25
3 changed files with 78 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
mysql-test/main/update.test
View File

@ -676,3 +676,41 @@ UPDATE t1,t2 SET t1.i1 = -39 WHERE t2.d1 <> t1.i1 AND t2.d1 = t1.d2;
DROP TABLE t1,t2;
--echo # End of MariaDB 10.2 tests
--echo #
--echo # MDEV-29189: Second execution of SF using UPDATE?DELETE
--echo # after reported error by the first execution
--echo #
CREATE TABLE t1 (c int);
DELIMITER //;
CREATE FUNCTION f1() RETURNS int
BEGIN
UPDATE t1 SET c=c+1;
RETURN 1;
END;//
CREATE FUNCTION f2() RETURNS int
BEGIN
DELETE FROM t1 WHERE c < 7;
RETURN 1;
END;//
DELIMITER ;//
INSERT INTO t1 VALUES (3), (7), (1);
--error ER_CANT_UPDATE_USED_TABLE_IN_SF_OR_TRG
SELECT * FROM t1 WHERE f1() = 1;
SELECT f1();
SELECT * FROM t1;
--error ER_CANT_UPDATE_USED_TABLE_IN_SF_OR_TRG
SELECT * FROM t1 WHERE f2() = 1;
SELECT f2();
SELECT * FROM t1;
DROP FUNCTION f1;
DROP FUNCTION f2;
DROP TABLE t1;
--echo # End of MariaDB 10.10 tests