database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-27 18:02:13 +03:00
Code Activity

MDEV-33655 Remove alter_algorithm

Browse Source 
Remove alter_algorithm but keep the variable as no-op (with a warning).

The reasons for removing alter_algorithm are:
- alter_algorithm was introduced as a replacement for the
  old_alter_table that was used to force the usage of the original
  alter table algorithm (copy) in the cases where the new alter
  algorithm did not work. The new option was added as a way to force
  the usage of a specific algorithm when it should instead have made
  it possible to disable algorithms that would not work for some
  reason.
- alter_algorithm introduced some cases where ALTER TABLE would not
  work without specifying the ALGORITHM=XXX option together with
  ALTER TABLE.
- Having different values of alter_algorithm on master and slave could
  cause slave to stop unexpectedly.
- ALTER TABLE FORCE, as used by mariadb-upgrade, would not always work
  if alter_algorithm was set for the server.
- As part of the MDEV-33449 "improving repair of tables" it become
  clear that alter- algorithm made it harder to provide a better and
  more consistent ALTER TABLE FORCE and REPAIR TABLE and it would be
  better to remove it.
This commit is contained in:
Monty
2024-03-12 13:54:30 +02:00
committed by Sergei Golubchik
parent 6254fcf84a
commit 2464ee758a
58 changed files with 1171 additions and 2205 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
mysql-test/suite/sys_vars/r/alter_algorithm_basic.result
View File

@ -1,89 +1,21 @@
SET @start_global_value = @@global.alter_algorithm;
SET GLOBAL alter_algorithm=1.1;
ERROR 42000: Incorrect argument type to variable 'alter_algorithm'
SET GLOBAL alter_algorithm=-1;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of '-1'
SET GLOBAL alter_algorithm=weird;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of 'weird'
SET GLOBAL alter_algorithm=4;
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
INSTANT
SET GLOBAL alter_algorithm=3;
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
NOCOPY
SET GLOBAL alter_algorithm=0;
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
DEFAULT
SET GLOBAL alter_algorithm=1;
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
COPY
SET GLOBAL alter_algorithm=2;
Warnings:
Warning 4200 The variable '@@alter_algorithm' is deleted and ignored. It it only exists for compatiblity with old installations
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
INPLACE
DEFAULT
SET GLOBAL alter_algorithm=5;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of '5'
SELECT @@global.alter_algorithm;
@@global.alter_algorithm
INPLACE
SET GLOBAL alter_algorithm=NOCOPY;
SET alter_algorithm=1.1;
ERROR 42000: Incorrect argument type to variable 'alter_algorithm'
SET alter_algorithm=-1;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of '-1'
SET alter_algorithm=weird;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of 'weird'
SET alter_algorithm=4;
SELECT @@alter_algorithm;
@@alter_algorithm
INSTANT
SET alter_algorithm=3;
SELECT @@alter_algorithm;
@@alter_algorithm
NOCOPY
SET alter_algorithm=0;
SELECT @@alter_algorithm;
@@alter_algorithm
DEFAULT
SET alter_algorithm=1;
SELECT @@alter_algorithm;
@@alter_algorithm
COPY
SET alter_algorithm=2;
SELECT @@alter_algorithm;
@@alter_algorithm
INPLACE
SET alter_algorithm=5;
ERROR 42000: Variable 'alter_algorithm' can't be set to the value of '5'
SELECT @@alter_algorithm;
@@alter_algorithm
INPLACE
SET SESSION alter_algorithm=INSTANT;
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm INSTANT
SET SESSION alter_algorithm=DEFAULT;
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm NOCOPY
SET SESSION alter_algorithm='DEFAULT';
Warnings:
Warning 4200 The variable '@@alter_algorithm' is deleted and ignored. It it only exists for compatiblity with old installations
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm DEFAULT
SET SESSION alter_algorithm=DEFAULT;
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm NOCOPY
SET GLOBAL alter_algorithm=DEFAULT;
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm NOCOPY
SET SESSION alter_algorithm=DEFAULT;
SHOW SESSION VARIABLES LIKE 'alter_algorithm';
Variable_name Value
alter_algorithm DEFAULT
SET GLOBAL alter_algorithm = @start_global_value;