database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

forbid REPLACE/ODKU on tables containing WITHOUT OVERLAPS

Browse Source
This commit is contained in:
Nikita Malyavin
2020-03-17 02:59:11 +10:00
committed by Sergei Golubchik
parent 62e7ad2bbc
commit 244ff3e5a0
5 changed files with 85 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
sql/sql_insert.cc
View File

@ -1410,6 +1410,33 @@ static bool check_view_insertability(THD * thd, TABLE_LIST *view)
}
/**
TODO remove when MDEV-17395 will be closed
Checks if REPLACE or ON DUPLICATE UPDATE was executed on table containing
WITHOUT OVERLAPS key.
@return
0 if no error
ER_NOT_SUPPORTED_YET if the above condidion was met
*/
int check_duplic_insert_without_overlaps(THD *thd, TABLE *table,
enum_duplicates duplic)
{
if (duplic == DUP_REPLACE || duplic == DUP_UPDATE)
{
for (uint k = 0; k < table->s->keys; k++)
{
if (table->key_info[k].without_overlaps)
{
my_error(ER_NOT_SUPPORTED_YET, MYF(0), "WITHOUT OVERLAPS");
return ER_NOT_SUPPORTED_YET;
}
}
}
return 0;
}
/*
Check if table can be updated
@ -1607,6 +1634,9 @@ bool mysql_prepare_insert(THD *thd, TABLE_LIST *table_list,
if (!table)
table= table_list->table;
if (check_duplic_insert_without_overlaps(thd, table, duplic) != 0)
DBUG_RETURN(true);
if (table->versioned(VERS_TIMESTAMP) && duplic == DUP_REPLACE)
{
// Additional memory may be required to create historical items.