database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

MDEV-31792 Assertion fails in MDL_context::acquire_lock upon parallel replication of CREATE SEQUENCE

Browse Source 
The assert's reason was in missed FL_DDL flagging of CREATE-or-REPLACE
Query event.
MDEV-27365 fixes covered only the non-pre-existing table execution branch so
did not see a possibility of implicit commit in
the middle of execution in a rollback branch when the being CREATEd
sequence table is actually replaced.
The pre-existing table branch cleared the DDL modification
flag so the query lost FL_DDL in binlog and its parallel execution
on slave may have ended up with the assert to indicate the query
is raced by a following in binlog order event.

Fixed with applying the MDEV-27365 pattern.
An mtr test is added to cover the rollback situation.
The description test [ pass ] with a generous number of mtr parallel
reties.
This commit is contained in:
Andrei
2023-10-23 12:53:12 +03:00
parent 5ca941caec
commit 1fe4a71b67
4 changed files with 87 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
mysql-test/suite/rpl/t/rpl_parallel_seq.test
View File

@@ -128,8 +128,51 @@ SET DEBUG_SYNC = 'now SIGNAL continue_worker';
SELECT @@global.gtid_binlog_state, @@global.gtid_slave_pos as "all through 101 have been committed";
# MDEV-31792 Assertion in MDL_context::acquire_lock upon parallel replication of CREATE SEQUENCE
--let $iter = 3
while ($iter)
{
--connection slave
if (`select $iter > 1`)
{
flush tables with read lock;
}
if (`select $iter = 1`)
{
BEGIN /* slave local Trx */;
select count(*) from s3;
}
--connection master
CREATE OR REPLACE SEQUENCE s3 ENGINE=innodb;
# select may return non-deterministically, don't print its result
SELECT NEXT VALUE FOR s3 into @tmpvar;
--source include/save_master_gtid.inc
--connection slave
--let $wait_condition= SELECT count(*) = 1 FROM information_schema.processlist WHERE state LIKE "Waiting for prior transaction to start commit%"
--source include/wait_condition.inc
if (`select $iter > 1`)
{
unlock tables;
}
if (`select $iter = 1`)
{
--connection slave
rollback /* Trx */;
}
--source include/sync_with_master_gtid.inc
--dec $iter
}
#
# MDEV-29621/MDEV-31077 clean up.
# MDEV-29621/MDEV-31077/MDEV-31792 clean up.
#
--connection slave
--source include/stop_slave.inc
@@ -142,7 +185,7 @@ SET debug_sync = RESET;
--source include/start_slave.inc
--connection master
DROP SEQUENCE s2;
DROP SEQUENCE s2,s3;
DROP TABLE ti;
--sync_slave_with_master