database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-27 18:02:13 +03:00
Code Activity

Addressing Monty's review suggestions for MDEV-11952 Oracle-style packages (partial)

Browse Source 
- Using array_elements() instead of a constant to iterate through an array
- Adding some comments
- Adding new-line function comments
- Using STRING_WITH_LEN instead of C_STRING_WITH_LEN
This commit is contained in:
Alexander Barkov
2018-05-21 13:26:16 +04:00
committed by Vladislav Vaintroub
parent 7d91d98ac1
commit 1e69d3f196
8 changed files with 99 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sql/sql_lex.h
View File

@ -319,13 +319,13 @@ enum enum_sp_aggregate_type
GROUP_AGGREGATE
};
const LEX_STRING sp_data_access_name[]=
const LEX_CSTRING sp_data_access_name[]=
{
{ C_STRING_WITH_LEN("") },
{ C_STRING_WITH_LEN("CONTAINS SQL") },
{ C_STRING_WITH_LEN("NO SQL") },
{ C_STRING_WITH_LEN("READS SQL DATA") },
{ C_STRING_WITH_LEN("MODIFIES SQL DATA") }
{ STRING_WITH_LEN("") },
{ STRING_WITH_LEN("CONTAINS SQL") },
{ STRING_WITH_LEN("NO SQL") },
{ STRING_WITH_LEN("READS SQL DATA") },
{ STRING_WITH_LEN("MODIFIES SQL DATA") }
};
#define DERIVED_SUBQUERY 1
@ -3685,7 +3685,7 @@ public:
Item *value);
sp_variable *sp_add_for_loop_upper_bound(THD *thd, Item *value)
{
LEX_CSTRING name= { C_STRING_WITH_LEN("[upper_bound]") };
LEX_CSTRING name= { STRING_WITH_LEN("[upper_bound]") };
return sp_add_for_loop_variable(thd, &name, value);
}
bool sp_for_loop_intrange_declarations(THD *thd, Lex_for_loop_st *loop,