database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

- Fix a few test in TYPVAL<PSZ> that cause Valgrind warnings

Browse Source 
modified:
  storage/connect/value.cpp

- Ignore column comment field in TabColumns because its pointer is flagged
  as invalid by Valgrind (this is a bypass but not a real fix)

modified:
  storage/connect/tabutil.cpp
  storage/connect/value.cpp
This commit is contained in:
Olivier Bertrand
2013-07-25 19:09:46 +02:00
parent 319414398f
commit 1c5c2c6db9
2 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
storage/connect/tabutil.cpp
View File

@ -226,8 +226,12 @@ PQRYRES TabColumns(PGLOBAL g, THD *thd, const char *db,
crp->Kdata->SetValue((fp->null_ptr != 0) ? 1 : 0, i);
crp = crp->Next; // Remark
fld = fp->comment.str;
crp->Kdata->SetValue(fld, fp->comment.length, i);
// For Valgrind until bug on comment storage is fixed
// if (fp->comment.length > 0 && (fld = fp->comment.str))
// crp->Kdata->SetValue(fld, fp->comment.length, i);
// else
crp->Kdata->Reset(i);
crp = crp->Next; // New
crp->Kdata->SetValue((fmt) ? fmt : (char*) "", i);