database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-27 18:02:13 +03:00
Code Activity

Optimize flush tables with read lock (FTWRL) to not wait for select's

Browse Source 
Part of MDEV-5336 Implement LOCK FOR BACKUP

The idea is that instead of waiting in close_cached_tables() for all
tables to be closed, we instead call flush_tables() that does:
- Flush not used objects in table cache to free memory
- Collect all tables that are open
- Call HA_EXTRA_FLUSH on the objects, to get them into "closed state"
- Added HA_EXTRA_FLUSH support to archive and CSV
- Added multi-user protection to HA_EXTRA_FLUSH in MyISAM and Aria

The benefit compared to old code is:
- FTWRL doesn't have to wait for long running read operations or
  open HANDLER's
This commit is contained in:
Monty
2018-10-09 18:55:18 +03:00
parent 306b7a2243
commit 163b34fe25
35 changed files with 456 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sql/sql_handler.cc
View File

@ -1196,10 +1196,10 @@ void mysql_ha_flush(THD *thd)
@note Broadcasts refresh if it closed a table with old version.
*/
void mysql_ha_cleanup(THD *thd)
void mysql_ha_cleanup_no_free(THD *thd)
{
SQL_HANDLER *hash_tables;
DBUG_ENTER("mysql_ha_cleanup");
DBUG_ENTER("mysql_ha_cleanup_no_free");
for (uint i= 0; i < thd->handler_tables_hash.records; i++)
{
@ -1207,9 +1207,15 @@ void mysql_ha_cleanup(THD *thd)
if (hash_tables->table)
mysql_ha_close_table(hash_tables);
}
DBUG_VOID_RETURN;
}
void mysql_ha_cleanup(THD *thd)
{
DBUG_ENTER("mysql_ha_cleanup");
mysql_ha_cleanup_no_free(thd);
my_hash_free(&thd->handler_tables_hash);
DBUG_VOID_RETURN;
}