database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

Bug#27499 DROP TABLE race with SHOW TABLE STATUS

Browse Source 
They can drop table after table names list creation and before table opening.
We open non existing table and get ER_NO_SUCH_TABLE error.
In this case we do not store the record into I_S table and clear error.
This commit is contained in:
gluh@mysql.com/eagle.(none)
2007-04-19 16:49:21 +05:00
parent 6ad81b4e13
commit 16223f0d75
1 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
sql/sql_show.cc
View File

@@ -2315,17 +2315,31 @@ int get_all_tables(THD *thd, TABLE_LIST *tables, COND *cond)
MYSQL_LOCK_IGNORE_FLUSH); MYSQL_LOCK_IGNORE_FLUSH);
lex->sql_command= save_sql_command; lex->sql_command= save_sql_command;
/* /*
We should use show_table_list->alias instead of They can drop table after table names list creation and
show_table_list->table_name because table_name before table opening. We open non existing table and
could be changed during opening of I_S tables. It's safe get ER_NO_SUCH_TABLE error. In this case we do not store
to use alias because alias contains original table name the record into I_S table and clear error.
in this case.
*/ */
res= schema_table->process_table(thd, show_table_list, table, if (thd->net.last_errno == ER_NO_SUCH_TABLE)
res, orig_base_name, {
show_table_list->alias); res= 0;
close_tables_for_reopen(thd, &show_table_list); thd->clear_error();
DBUG_ASSERT(!lex->query_tables_own_last); }
else
{
/*
We should use show_table_list->alias instead of
show_table_list->table_name because table_name
could be changed during opening of I_S tables. It's safe
to use alias because alias contains original table name
in this case.
*/
res= schema_table->process_table(thd, show_table_list, table,
res, orig_base_name,
show_table_list->alias);
close_tables_for_reopen(thd, &show_table_list);
DBUG_ASSERT(!lex->query_tables_own_last);
}
if (res) if (res)
goto err; goto err;
} }