database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-13720 Server crashes in SEQUENCE::write_lock for temporary tables

Browse Source 
This happens when doing NEXT VALUE for a temporary table
Fixed by giving ER_NOT_SEQUENCE when trying to use normal temporary table with
sequence functions

Signed-off-by: Monty <monty@mariadb.org>
This commit is contained in:
Aleksey Midenkov
2017-10-14 17:31:57 +03:00
committed by Monty
parent eea07f5f58
commit 1355fadb59
3 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mysql-test/suite/sql_sequence/next.result
View File

@ -512,3 +512,10 @@ def PREVIOUS VALUE FOR s1 8 20 1 Y 32896 0 63
NEXT VALUE FOR s1 PREVIOUS VALUE FOR s1
1 1
DROP SEQUENCE s1;
#
# MDEV-13720 ER_NOT_SEQUENCE for temporary table
#
create temporary table tmp (i int);
select next value for tmp;
ERROR 42S02: 'test.tmp' is not a SEQUENCE
drop table tmp;

9
mysql-test/suite/sql_sequence/next.test
View File

@ -260,3 +260,12 @@ SELECT
DROP SEQUENCE s1;
--enable_ps_protocol
--disable_metadata
--echo #
--echo # MDEV-13720 ER_NOT_SEQUENCE for temporary table
--echo #
create temporary table tmp (i int);
--error ER_NOT_SEQUENCE
select next value for tmp;
drop table tmp;

5
sql/sql_base.cc
View File

@ -3341,6 +3341,11 @@ open_and_process_table(THD *thd, LEX *lex, TABLE_LIST *tables,
temporary table or SEQUENCE (see sequence_insert()).
*/
DBUG_ASSERT(is_temporary_table(tables) || tables->table->s->sequence);
if (tables->sequence && tables->table->s->table_type != TABLE_TYPE_SEQUENCE)
{
my_error(ER_NOT_SEQUENCE, MYF(0), tables->db, tables->alias);
DBUG_RETURN(true);
}
}
else if (tables->open_type == OT_TEMPORARY_ONLY)
{