database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-27 18:02:13 +03:00
Code Activity

Fix for Bug#6024 "Test "client_test" fails in 4.1.6-gamma build (1)":

Browse Source 
let's not assume that char is signed (its signedness is not defined).
The server was also affected by the wrong typedef.
This commit is contained in:
konstantin@mysql.com
2004-10-15 03:54:40 +04:00
parent 60fc4ed057
commit 105a2c1c03
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/my_global.h
View File

@ -713,7 +713,7 @@ typedef void *gptr; /* Generic pointer */
typedef char *gptr; /* Generic pointer */ typedef char *gptr; /* Generic pointer */
#endif #endif
#ifndef HAVE_INT_8_16_32 #ifndef HAVE_INT_8_16_32
typedef char int8; /* Signed integer >= 8 bits */ typedef signed char int8; /* Signed integer >= 8 bits */
typedef short int16; /* Signed integer >= 16 bits */ typedef short int16; /* Signed integer >= 16 bits */
#endif #endif
#ifndef HAVE_UCHAR #ifndef HAVE_UCHAR

7
libmysql/libmysql.c
View File

@ -3611,9 +3611,10 @@ static void fetch_result_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field,
switch (field_type) { switch (field_type) {
case MYSQL_TYPE_TINY: case MYSQL_TYPE_TINY:
{ {
char value= (char) **row; uchar value= **row;
longlong data= field_is_unsigned ? (longlong) (unsigned char) value : /* sic: we need to cast to 'signed char' as 'char' may be unsigned */
(longlong) value; longlong data= field_is_unsigned ? (longlong) value :
(longlong) (signed char) value;
fetch_long_with_conversion(param, field, data); fetch_long_with_conversion(param, field, data);
*row+= 1; *row+= 1;
break; break;