database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Adding a "const" qualifier to arguments of create_func(), create_native() etc

Browse Source 
The "const" qualifier was obviously forgotten.

This change will also simpily fixing of MDEV-27744.
This commit is contained in:
Alexander Barkov
2022-04-04 09:45:29 +04:00
parent d271fbd392
commit 0ffaf19c53
3 changed files with 215 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugin/versioning/versioning.cc
View File

@ -29,7 +29,8 @@ template <TR_table::field_id_t TRT_FIELD>
class Create_func_trt : public Create_native_func
{
public:
virtual Item *create_native(THD *thd, LEX_CSTRING *name, List<Item> *item_list);
virtual Item *create_native(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list);
static Create_func_trt<TRT_FIELD> s_singleton;
@ -43,7 +44,7 @@ Create_func_trt<TRT_FIELD> Create_func_trt<TRT_FIELD>::s_singleton;
template <TR_table::field_id_t TRT_FIELD>
Item*
Create_func_trt<TRT_FIELD>::create_native(THD *thd, LEX_CSTRING *name,
Create_func_trt<TRT_FIELD>::create_native(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list)
{
Item *func= NULL;
@ -102,7 +103,8 @@ template <class Item_func_trt_trx_seesX>
class Create_func_trt_trx_sees : public Create_native_func
{
public:
virtual Item *create_native(THD *thd, LEX_CSTRING *name, List<Item> *item_list)
virtual Item *create_native(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list)
{
Item *func= NULL;
int arg_count= 0;

314
sql/item_create.cc
View File

File diff suppressed because it is too large Load Diff

15
sql/item_create.h
View File

@ -58,7 +58,8 @@ public:
@param item_list The list of arguments to the function, can be NULL
@return An item representing the parsed function call, or NULL
*/
virtual Item *create_func(THD *thd, LEX_CSTRING *name, List<Item> *item_list) = 0;
virtual Item *create_func(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list) = 0;
protected:
/** Constructor */
@ -79,7 +80,7 @@ protected:
class Create_native_func : public Create_func
{
public:
virtual Item *create_func(THD *thd, LEX_CSTRING *name,
virtual Item *create_func(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list);
/**
@ -89,7 +90,7 @@ public:
@param item_list The function parameters, none of which are named
@return An item representing the function call
*/
virtual Item *create_native(THD *thd, LEX_CSTRING *name,
virtual Item *create_native(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list) = 0;
protected:
@ -117,7 +118,7 @@ public:
@param item_list The list of arguments to the function, can be NULL
@return An item representing the parsed function call
*/
virtual Item *create_func(THD *thd, LEX_CSTRING *name,
virtual Item *create_func(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list);
/**
@ -129,7 +130,9 @@ public:
@param item_list The list of arguments to the function, can be NULL
@return An item representing the parsed function call
*/
virtual Item *create_with_db(THD *thd, LEX_CSTRING *db, LEX_CSTRING *name,
virtual Item *create_with_db(THD *thd,
const LEX_CSTRING *db,
const LEX_CSTRING *name,
bool use_explicit_name,
List<Item> *item_list) = 0;
@ -167,7 +170,7 @@ extern Create_qfunc * find_qualified_function_builder(THD *thd);
class Create_udf_func : public Create_func
{
public:
virtual Item *create_func(THD *thd, LEX_CSTRING *name,
virtual Item *create_func(THD *thd, const LEX_CSTRING *name,
List<Item> *item_list);
/**